Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhysicalInfraTopologyService spec - expect manager to have Valid status, not nil #5120

Merged
merged 1 commit into from
Jan 3, 2019
Merged

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Jan 3, 2019

This changed because of ManageIQ/manageiq#18266,
just making sure the tests are green again.

Fixes red travis: (tracking issue #4921 (comment))

https://travis-ci.org/ManageIQ/manageiq-ui-classic/jobs/474623058

  1) PhysicalInfraTopologyService#build_topology topology contains the expected structure and content
     Failure/Error:
       expect(subject[:items]).to eq(
         "PhysicalInfraManager" + ems.id.to_s  => {
           :name         => ems.name,
           :kind         => "PhysicalInfraManager",
           :miq_id       => ems.id,
           :status       => nil,
           :display_kind => "Lenovo",
           :model        => ems.class.name,
           :key          => "PhysicalInfraManager" + ems.id.to_s
         },
       expected: {"PhysicalInfraManager96000000000077"=>{:name=>"LXCA", :kind=>"PhysicalInfraManager", :miq_id=>960000...PhysicalServer", :provider=>"LXCA", :model=>"PhysicalServer", :key=>"PhysicalServer96000000000004"}}
            got: {"PhysicalInfraManager96000000000077"=>{:name=>"LXCA", :kind=>"PhysicalInfraManager", :model=>"Manage..."PhysicalRack96000000000001", :status=>"Unknown", :display_kind=>"PhysicalRack", :provider=>"LXCA"}}

(hidden in the diff, but expected has :status => nil, while actual has :status => 'Valid').

…us, not nil

changed because of ManageIQ/manageiq#18266,
just making sure the tests are green again.
@martinpovolny martinpovolny merged commit 6332d21 into ManageIQ:master Jan 3, 2019
@martinpovolny martinpovolny self-assigned this Jan 3, 2019
@martinpovolny martinpovolny added this to the Sprint 102 Ending Jan 7, 2019 milestone Jan 3, 2019
@himdel himdel deleted the travis-ems-valid branch January 3, 2019 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants