Ems factory uses valid authentications #18266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrock
force-pushed
the
ems_factories_valid
branch
2 times, most recently
from
ae7d5ef
to
b6f1c39
Compare
1 task
|
This pull request is not mergeable. Please rebase and repush. |
The current `:authentication` factory is ambiguous. Most of the places it is used just want a valid authentication. Since the default authentication is not valid for many cases, we just stub out authentication rather than use the proper form. Any time we do not want a valid authentication, we state otherwise. I originally created an `authentication_valid` factory. But it became confusing when to use `authentication` and when to use `authentication_valid`.
kbrock
force-pushed
the
ems_factories_valid
branch
from
cce6a36
to
f008749
Compare
|
Checked commits kbrock/manageiq@277544d~...f008749 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Causes ui-classic travis failure (a PhysicalInfraManager fresh from the factory now has |
This was referenced Jan 3, 2019
cben
added a commit
to cben/manageiq-providers-kubernetes
that referenced
this pull request
Jan 3, 2019
ManageIQ/manageiq#18266 changed factories by default to create "Valid" auth, requiring explicit opt-out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
:authenticationfactory is ambiguous.Most of the places we want to use a valid authentication.
Any time we want an invalid authentication, we state otherwise.
Unfortunately, since the default authentication is not valid for many cases, we end up stubbing out the values in our specs.
After This PR
From here, we can remove stubbing of authentication in providers [example]