Revert faster services PR 5366 #5768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3f609da, reversing changes made to 2f31e65. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1722491
|
/cc @skateman |
|
Checked commit kbrock@a72c9b4 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@kbrock is it possible that after ManageIQ/manageiq#18936 the issue is no longer reproducible and so this one is obsolete? |
|
@skateman I'm able to reproduce on services page. Not on any other areas. |
@skateman This flag overrides the MIQ code |
|
I'm fine with reverting this for now if it breaks ordering and pagination. 👍 |
simaishi
pushed a commit
that referenced
this pull request
Jul 8, 2019
Revert faster services PR 5366 (cherry picked from commit aed816c) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1728033
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were able to speed up the services page, but we lost sorting and proper pagination. So we are temporarily reverting #5366
This reverts commit 3f609da, reversing
changes made to 2f31e65.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1722491
NOTE: This page is now slow again. This change and other code fixes will need to be introduced again in another PR.
@miq-bot add_label bug, hammer/yes, services