default inline_sql_views (aka turbo button) off

[kbrock]

Overview

Using an inline view (SELECT statement in the FROM clause) allows the database to do much less work. This resulted in some pages going from a few minutes to a few seconds:

• Services Screen (Hammer) /via Services use turbo button manageiq-ui-classic#5366
• All pages (Ivanchuck) /via default to using inline sql views for reports #18822

Problem (before)

Turbo Button is not mature and has bugs:

• Some queries are missing a DISTINCT.
• total record count is wrong and therefore page count
• not all pages contain 20 records
• the sorting (ORDER) is ignored

After

We are temporarily turning it off :inline_sql_views.
This will slow down most pages, especially the Hosts, Vms and Services pages.

We will introduce these changes to fix bugs in Hammer and Ivanchuck.
We will possibly turn back on :inline_sql_views once these are fixed

See also:

• services page Revert faster services PR 5366  manageiq-ui-classic#5768
• https://bugzilla.redhat.com/show_bug.cgi?id=1722491

[NickLaMuro]

I like the idea of moving this to a class method so we can easily re-enable this in the future.

Sorry this didn't work out, but I kinda expected this wouldn't be that easy to implement and there would be a lot of edge cases surrounding it.

[miq-bot]

Checked commit kbrock@39e25c4 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🏆