Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the OPS/Database screen with the possibility of re-enabling #6106

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

skateman
Copy link
Member

@skateman skateman commented Aug 27, 2019

As discussed with PM in the BZ, we're hiding this screen with the possibility of displaying it by setting a configuration param.

@miq-bot add_reviewer @hstastna
@miq-bot add_reviewer @romanblanco
@miq-bot add_label pending core, ivanchuk/yes, bug, enhancement

Depends on ManageIQ/manageiq#19208
Closes #6084
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1744542

@miq-bot
Copy link
Member

miq-bot commented Aug 27, 2019

Checked commit skateman@f1e5c6d with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

Copy link

@hstastna hstastna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, your changes make the Database accordion hidden.
ops_db

@h-kataria h-kataria self-assigned this Aug 27, 2019
@h-kataria h-kataria added this to the Sprint 119 Ending Sep 2, 2019 milestone Aug 27, 2019
@h-kataria h-kataria merged commit a963e0c into ManageIQ:master Aug 27, 2019
@skateman skateman deleted the hide-ops-database branch August 27, 2019 13:46
simaishi pushed a commit that referenced this pull request Oct 31, 2019
Hide the OPS/Database screen with the possibility of re-enabling

(cherry picked from commit a963e0c)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767645
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit 86354c43e467148232a60a7d6e85129913cac258
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Tue Aug 27 09:29:24 2019 -0400

    Merge pull request #6106 from skateman/hide-ops-database
    
    Hide the OPS/Database screen with the possibility of re-enabling
    
    (cherry picked from commit a963e0cac462a38307c3ce82d79d0a773e7d75bd)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767645

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants