Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Settings attribute for displaying the ops/database screen #19208

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

skateman
Copy link
Member

@skateman skateman commented Aug 27, 2019

As we discussed with PM in the BZ, we're hiding the screen with the possibility of re-displaying it by setting a configuartion parameter. Of course this requires a configuration parameter first. I'm not sure if I'm putting it into the right place though, cc @mzazrivec as everyone else is on PTO.

@miq-bot add_reviewer @mzazrivec
@miq-bot add_reviewer @lpichler
@miq-bot add_label enhancement, ivanchuk/yes, bug

https://bugzilla.redhat.com/show_bug.cgi?id=1744542

@miq-bot
Copy link
Member

miq-bot commented Aug 27, 2019

Checked commit skateman@20e1516 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

Copy link
Contributor

@lpichler lpichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with this 👍

@lpichler
Copy link
Contributor

@miq-bot assign @bdunne

@h-kataria h-kataria added this to the Sprint 119 Ending Sep 2, 2019 milestone Aug 27, 2019
@h-kataria h-kataria assigned h-kataria and unassigned bdunne Aug 27, 2019
@h-kataria h-kataria merged commit 82f109f into ManageIQ:master Aug 27, 2019
@skateman skateman deleted the hide-ops-database branch August 27, 2019 13:47
simaishi pushed a commit that referenced this pull request Oct 31, 2019
Add Settings attribute for displaying the ops/database screen

(cherry picked from commit 82f109f)

https://bugzilla.redhat.com/show_bug.cgi?id=1767645
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit 279b1041e36405c7fca60003afdf3026c201dab3
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Tue Aug 27 09:28:31 2019 -0400

    Merge pull request #19208 from skateman/hide-ops-database
    
    Add Settings attribute for displaying the ops/database screen
    
    (cherry picked from commit 82f109f87769b99ac1e8d175bf7b6b1aa481d5dd)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1767645

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants