Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tree_builder_sections_spec #7214

Conversation

mzazrivec
Copy link
Contributor

This is to fix the following CI failure:

1) TreeBuilderSections TreeBuilderSections sets roots correctly
     Failure/Error:
       expect(roots).to eq([{:id         => "group_Properties",
                             :text       => "Properties",
                             :tip        => "Properties",
                             :image      => false,
                             :selectable => false,
                             :nodes      => [{:name => :_model_, :header => "Filesystem", :group => "Properties"}]}])
     
       expected: [{:id=>"group_Properties", :image=>false, :nodes=>[{:group=>"Properties", :header=>"Filesystem", :name=>:_model_}], :selectable=>false, :text=>"Properties", :tip=>"Properties"}]
            got: [{:id=>"group_Properties", :image=>false, :nodes=>[{:group=>"Properties", :header=>"File", :name=>:_model_}], :selectable=>false, :text=>"Properties", :tip=>"Properties"}]
     
       (compared using ==)
     
       Diff:
       @@ -1,6 +1,6 @@
        [{:id=>"group_Properties",
          :image=>false,
       -  :nodes=>[{:group=>"Properties", :header=>"Filesystem", :name=>:_model_}],
       +  :nodes=>[{:group=>"Properties", :header=>"File", :name=>:_model_}],
          :selectable=>false,
          :text=>"Properties",
          :tip=>"Properties"}]
       
     # ./spec/presenters/tree_builder_sections_spec.rb:74:in `block (3 levels) in <top (required)>'
  2) TreeBuilderSections TreeBuilderSections sets children correctly
     Failure/Error:
       expect(kids).to eq([{:id         => "group_Properties:_model_",
                            :text       => "Filesystem",
                            :tip        => "Filesystem",
                            :image      => false,
                            :selectable => false,
                            :checked    => true,
                            :nodes      => []}])
     
       expected: [{:checked=>true, :id=>"group_Properties:_model_", :image=>false, :nodes=>[], :selectable=>false, :text=>"Filesystem", :tip=>"Filesystem"}]
            got: [{:checked=>true, :id=>"group_Properties:_model_", :image=>false, :nodes=>[], :selectable=>false, :text=>"File", :tip=>"File"}]
     
       (compared using ==)
     
       Diff:
       @@ -3,6 +3,6 @@
          :image=>false,
          :nodes=>[],
          :selectable=>false,
       -  :text=>"Filesystem",
       -  :tip=>"Filesystem"}]
       +  :text=>"File",
       +  :tip=>"File"}]
       
     # ./spec/presenters/tree_builder_sections_spec.rb:85:in `block (3 levels) in <top (required)>'

coming from ManageIQ/manageiq#20361

@miq-bot
Copy link
Member

miq-bot commented Jul 17, 2020

Checked commit mzazrivec@5ff6ab7 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🏆

Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval

@skateman skateman self-assigned this Jul 17, 2020
@skateman skateman merged commit 682a5dd into ManageIQ:master Jul 17, 2020
@mzazrivec mzazrivec deleted the fix_failing_ci_in_tree_builder_sections_spec branch July 17, 2020 08:36
simaishi pushed a commit that referenced this pull request Jul 17, 2020
…r_sections_spec

Fix failing tree_builder_sections_spec

(cherry picked from commit 682a5dd)
@simaishi
Copy link
Contributor

Jansa backport details:

$ git log -1
commit 3f91c34a3bb390757a0addf4429889dc369dddbc
Author: Halász Dávid <skateman@users.noreply.github.com>
Date:   Fri Jul 17 10:23:23 2020 +0200

    Merge pull request #7214 from mzazrivec/fix_failing_ci_in_tree_builder_sections_spec

    Fix failing tree_builder_sections_spec

    (cherry picked from commit 682a5dd95cdca9a8e5974a9a3ab3367751c66e4c)

@bdunne
Copy link
Member

bdunne commented Jul 17, 2020

Should https://github.com/ManageIQ/manageiq/blob/f8452000ba72ef6b72c49a85cf5532e5c17b4f4a/locale/en.yml#L736 have been changed instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants