Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure remaining models are translated but not through rails' titleize #20361

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Ensure remaining models are translated but not through rails' titleize #20361

merged 1 commit into from
Jul 16, 2020

Conversation

jrafanie
Copy link
Member

@jrafanie jrafanie commented Jul 16, 2020 •
edited
Loading

ui_lookup already deals with going to gettext and should be used for translating models by default. Delegating to titleize was something did before gettext and ui_lookup was rebust enough to be used but now that it is, we need to use it.

@jrafanie jrafanie requested a review from h-kataria July 16, 2020 14:33
@miq-bot
Copy link
Member

miq-bot commented Jul 16, 2020

Checked commit jrafanie@ca162ce with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@h-kataria h-kataria self-assigned this Jul 16, 2020
@h-kataria h-kataria merged commit d6ea037 into ManageIQ:master Jul 16, 2020
@jrafanie jrafanie deleted the translate_compare_section_headers_for_all_models branch July 16, 2020 17:45
simaishi pushed a commit that referenced this pull request Jul 16, 2020
@h-kataria @simaishi
Merge pull request #20361 from jrafanie/translate_compare_section_hea…
3873fd2 
…ders_for_all_models

Ensure remaining models are translated but not through rails' titleize

(cherry picked from commit d6ea037)
@simaishi
Copy link
Contributor

Jansa backport details:

$ git log -1
commit 3873fd2d238f8f59ee755e1e7f45a7e5dcdbeacf
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Thu Jul 16 12:31:13 2020 -0400

    Merge pull request #20361 from jrafanie/translate_compare_section_headers_for_all_models

    Ensure remaining models are translated but not through rails' titleize

    (cherry picked from commit d6ea037cf8cae7d709a5438cc19f94c9861651ad)

This was referenced Jul 17, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-kataria h-kataria h-kataria approved these changes

@agrare agrare Awaiting requested review from agrare agrare is a code owner

@Fryguy Fryguy Awaiting requested review from Fryguy Fryguy is a code owner

@gtanzillo gtanzillo Awaiting requested review from gtanzillo

@kbrock kbrock Awaiting requested review from kbrock kbrock is a code owner

Assignees

@h-kataria h-kataria

Labels
bug internationalization jansa/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jrafanie @miq-bot @simaishi @h-kataria @gtanzillo