Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use textarea for ssh key in Machine Credentials #976

Merged
merged 1 commit into from
Apr 20, 2017
Merged

Use textarea for ssh key in Machine Credentials #976

merged 1 commit into from
Apr 20, 2017

Conversation

ZitaNemeckova
Copy link
Contributor

@ZitaNemeckova ZitaNemeckova commented Apr 10, 2017 •
edited
Loading

Using textarea prevents lost of EOL chars which was making input invalid

@miq-bot add_label fine/yes, wip, automation/ansible, bug, pending core

Waiting on ManageIQ/manageiq#14707 (merged)

https://bugzilla.redhat.com/show_bug.cgi?id=1439589

@ZitaNemeckova
Use textarea for ssh key in Machine Credentials
2d3a0f1 
Using textarea prevents lost of EOL chars and making input invalid
@miq-bot
Copy link
Member

miq-bot commented Apr 10, 2017

@ZitaNemeckova Cannot apply the following label because they are not recognized: core pending

@miq-bot miq-bot changed the title Use textarea for ssh key in Machine Credentials [WIP] Use textarea for ssh key in Machine Credentials Apr 10, 2017
@ZitaNemeckova ZitaNemeckova mentioned this pull request Apr 10, 2017
Merged
@miq-bot
Copy link
Member

miq-bot commented Apr 10, 2017

Checked commit ZitaNemeckova@2d3a0f1 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. 👍

@Fryguy
Copy link
Member

Fryguy commented Apr 11, 2017

ManageIQ/manageiq#14707 merged

@ZitaNemeckova
Copy link
Contributor Author

@miq-bot add_label blocker

@mzazrivec please review, thanks :)

@ZitaNemeckova
Copy link
Contributor Author

@miq-bot remove_label wip

@miq-bot miq-bot changed the title [WIP] Use textarea for ssh key in Machine Credentials Use textarea for ssh key in Machine Credentials Apr 20, 2017
@miq-bot miq-bot removed the wip label Apr 20, 2017
@mzazrivec mzazrivec self-assigned this Apr 20, 2017
@mzazrivec mzazrivec added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 20, 2017
@mzazrivec mzazrivec merged commit 554c1d7 into ManageIQ:master Apr 20, 2017
simaishi pushed a commit that referenced this pull request Apr 20, 2017
@mzazrivec @simaishi
Merge pull request #976 from ZitaNemeckova/credential_fix
35ccd42 
Use textarea for ssh key in Machine Credentials
(cherry picked from commit 554c1d7)
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 35ccd42c658fdbe7913774a03887a6be28a79f61
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Thu Apr 20 10:55:55 2017 +0200

    Merge pull request #976 from ZitaNemeckova/credential_fix
    
    Use textarea for ssh key in Machine Credentials
    (cherry picked from commit 554c1d72372a10145c94d7b0afbce5fb650dac85)

@ZitaNemeckova ZitaNemeckova deleted the credential_fix branch September 12, 2017 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
automation/ansible blocker bug fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ZitaNemeckova @miq-bot @Fryguy @simaishi @mzazrivec