Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiline to ssh attribute #14707

Merged
merged 1 commit into from
Apr 11, 2017
Merged

Conversation

ZitaNemeckova
Copy link
Contributor

UI needs to know that ssh attribute needs to consider it as multiline otherwise it removes EOL chars and makes ssh key invalid

@miq-bot add_label bug, providers/ansible_tower, fine/yes

@jameswnl please review, thanks :)

Links

https://bugzilla.redhat.com/show_bug.cgi?id=1439589
Needed by ManageIQ/manageiq-ui-classic#976

UI needs to know that ssh attribute needs to consider it as multiline otherwise it removes EOL chars and makes ssh key invalid
@miq-bot
Copy link
Member

miq-bot commented Apr 10, 2017

Checked commit ZitaNemeckova@de8efbf with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 1 offense detected

app/models/manageiq/providers/ansible_tower/shared/automation_manager/machine_credential.rb

  • ❗ - Line 19, Col 7 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.

@jameswnl
Copy link
Contributor

LGTM

@Fryguy Fryguy merged commit f7aa719 into ManageIQ:master Apr 11, 2017
@Fryguy Fryguy added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 11, 2017
@Fryguy Fryguy self-assigned this Apr 11, 2017
simaishi pushed a commit that referenced this pull request Apr 13, 2017
Add multiline to ssh attribute
(cherry picked from commit f7aa719)
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 733bbd5dbd38873bdc24c0c50fb4765316c01225
Author: Jason Frey <fryguy9@gmail.com>
Date:   Tue Apr 11 13:18:02 2017 -0400

    Merge pull request #14707 from ZitaNemeckova/credential_ssh
    
    Add multiline to ssh attribute
    (cherry picked from commit f7aa7195779bd9a966c544aec0ad0740f071c4b1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants