Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hint to UI that scm_credential private_key field should have multiple-line #15109

Merged
merged 1 commit into from
May 16, 2017

Conversation

jameswnl
Copy link
Contributor

@jameswnl jameswnl commented May 16, 2017

https://bugzilla.redhat.com/show_bug.cgi?id=1451326

Whiling reviewing #14707, it didn't come to my mind that other similar private_key fields need the same change.

Also corrected two field labels.
@miq-bot add_labels bug, blocker, providers/ansible_tower

@miq-bot
Copy link
Member

miq-bot commented May 16, 2017

Checked commit jameswnl@f7f5b42 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 1 offense detected

app/models/manageiq/providers/ansible_tower/shared/automation_manager/scm_credential.rb

  • ❗ - Line 25, Col 7 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.

@blomquisg blomquisg self-requested a review May 16, 2017 16:43
@blomquisg blomquisg self-assigned this May 16, 2017
@blomquisg blomquisg merged commit 4e7fe00 into ManageIQ:master May 16, 2017
@blomquisg blomquisg added this to the Sprint 61 Ending May 22, 2017 milestone May 16, 2017
simaishi pushed a commit that referenced this pull request May 17, 2017
Hint to UI that scm_credential private_key field should have multiple-line
(cherry picked from commit 4e7fe00)

https://bugzilla.redhat.com/show_bug.cgi?id=1451780
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 119e6fddaa7a93dccd51469da25e8beb5d928577
Author: Greg Blomquist <blomquisg@gmail.com>
Date:   Tue May 16 18:22:29 2017 -0400

    Merge pull request #15109 from jameswnl/private_key
    
    Hint to UI that scm_credential private_key field should have multiple-line
    (cherry picked from commit 4e7fe00240fcfe262c05cf2c3cadb77382d37293)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1451780

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants