Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

[Abandoned][#370] Cancel Migration Plan / Cancel Mike's Plans #509

Closed
wants to merge 2 commits into from

Conversation

mturley
Copy link
Contributor

@mturley mturley commented Jul 19, 2018

Okay. So, this one is a doozy for a few reasons:

  • It comes during a pretty tumultuous time where I have had a good half of my productive hours consumed by unexpected personal time-- i'll loop back with Cat about that to be sure it's reflected correctly.. 🤔
  • I made these two Redux commits on Friday and Wednesday, with the assumption that it was a single JSON property we were going to plug in for a whole plan's cancellation-- I missed the memo that we had an API for task cancellation until it was in my lap, which is my own fault. So I've done some rework since these commits that isn't ready to push quite yet.
  • I have been working on the React side of things since these, because I wanted to jump to doing things top-down like I started doing with Pre & Post Playbook Support - Overview Page Changes #399. So, these Redux commits for an action to cancel the entire plan might not be wasted, but they need to live alongside other Redux work. @priley86 maybe this is where you can help me today. I'm sorry I didn't ask sooner, I wanted to just get things together and get it all done. It's really not much work...
  • Some other things I can't think of, there's a meeting in 3 minutes, I'm going to stop typing now.

Edit: there is no need for an action to cancel the entire plan, a plan can just have all of its tasks cancelled. So we are abandoning this PR and some of my work will carry over to Patrick's new PR #511.

@mturley mturley self-assigned this Jul 19, 2018
@mturley
Copy link
Contributor Author

mturley commented Jul 19, 2018

@AllenBW I screwed up the PR naming again, can ya fix it for me?

@mturley
Copy link
Contributor Author

mturley commented Jul 19, 2018

Oops, I missed the Issue number too. 1 sec.

@AllenBW
Copy link
Member

AllenBW commented Jul 19, 2018

@AllenBW AllenBW changed the title [Very WIP] Cancel Migration Plan / Cancel Mike's Plans [WIP] Cancel Migration Plan / Cancel Mike's Plans Jul 19, 2018
@AllenBW AllenBW added the wip label Jul 19, 2018
@mturley mturley changed the title [WIP] Cancel Migration Plan / Cancel Mike's Plans [WIP][#370] Cancel Migration Plan / Cancel Mike's Plans Jul 19, 2018
@priley86
Copy link
Member

I would go ahead and rebase this on top of #442 (since it also touches Plan Details screen) @mturley. I'm working the Redux pieces now...

@mturley
Copy link
Contributor Author

mturley commented Jul 20, 2018

Closing this one, we are using Patrick's PR #511 instead.

@mturley mturley closed this Jul 20, 2018
@mturley mturley deleted the cancel-plan branch July 20, 2018 22:51
@mturley mturley changed the title [WIP][#370] Cancel Migration Plan / Cancel Mike's Plans [Abandoned][#370] Cancel Migration Plan / Cancel Mike's Plans Jul 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants