This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
[WIP][#370] Cancel a migration's tasks #511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mturley
changed the title
|
I'm now unblocked and back to working on this. I added the "X of Y selected" piece under the cancel button. Working on Select All next.
|
mturley
force-pushed
the
cancel-migration
branch
from
37c375d
to
bf432b1
Compare
[WIP] Import DropdownButton [WIP] Conditionally render log links [WIP] Update mock data [WIP] Update log link rendering [WIP] Fetch running playbook [WIP] Display playbook name in popover [WIP] i18n [WIP] Fix mocks [WIP] Update fixtures [WIP] Update playbook status [WIP] Update popover content [WIP] Update fetching ansible playbook template [WIP] Fix Popover formatting [WIP] Use status constants [WIP] Test errors [WIP] Real action for fetching playbook template [WIP] Mock fetching OrchestrationStack [WIP] Remove mock responses and data
mturley
force-pushed
the
cancel-migration
branch
from
bf432b1
to
6a5170b
Compare
mturley
force-pushed
the
cancel-migration
branch
from
6a5170b
to
928f864
Compare
michaelkro
reviewed
Jul 25, 2018
| notificationType: 'error', | ||
| persistent: true, | ||
| actionEnabled: false | ||
| }); | ||
| reject(e); |
There was a problem hiding this comment.
This will result with duplicate error messages as we started getting error notification for free when we moved away from using axios to make requests to the MIQ API. (review comment)
| if (task.options.playbooks) { | ||
| const hasPlaybookService = task.options.playbooks; | ||
|
|
||
| if (hasPlaybookService) { |
There was a problem hiding this comment.
We removed the unnecessary const declaration and moved task.options.playbooks directly into the conditional here (review comment)
| @@ -247,7 +247,7 @@ class PlanRequestDetailList extends React.Component { | |||
| overlayTriggerClick = task => { | |||
| if (task.options.playbooks) { | |||
| const playbookStatuses = task.options.playbooks; | |||
| let runningPlaybook = null; | |||
| let runningPlaybook; | |||
There was a problem hiding this comment.
We set the default value to null here (review comment)
|
This work is now being handled in another PR. PR shuffle 👉 #517 👉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #370
fixes https://bugzilla.redhat.com/show_bug.cgi?id=1564257
refactors #509
Work completed:
Work remaining:
task['options']['cancellation_request_id']already in our existing tasks list.Edge case discovered: