Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Migration completed notifications should also appear on detail screen #265

Closed
priley86 opened this issue Apr 30, 2018 · 10 comments
Closed

Migration completed notifications should also appear on detail screen #265

priley86 opened this issue Apr 30, 2018 · 10 comments
Assignees
@AparnaKarve
Labels
enhancement Sprint 12

Comments

@priley86
Copy link
Member

  • to fix this, we can bubble up the _getTransformationPlansActionCreator redux call a level in the hierarchy (so that polling occurs for that request on both Overview and Overview Detail).

I'm fine w/ deferring this for now...
@priley86 priley86 mentioned this issue Apr 30, 2018
Merged
@mturley mturley self-assigned this Jul 24, 2018
@mturley
Copy link
Contributor

mturley commented Jul 24, 2018

Starting on this tomorrow, unless @AparnaKarve can use my help in finishing the Redux part of #511.

@mturley mturley assigned AparnaKarve and unassigned mturley Jul 25, 2018
@mturley
Copy link
Contributor

mturley commented Jul 25, 2018

Talked to @AparnaKarve, she is working on higher priority things but she had already started this one. Starting on #240 instead.

@AparnaKarve AparnaKarve mentioned this issue Aug 6, 2018
Merged
@michaelkro
Copy link
Contributor

michaelkro commented Aug 6, 2018 •
edited
Loading

@priley86 @AparnaKarve @vconzola

It was my impression that this issue concerned showing alerts of migration plans completing, as opposed to individual migration tasks.

e.g., you could be viewing the details page for migration plan 1 and when migration plan 2 completes/fails, the notification would appear.

@vconzola
Copy link

vconzola commented Aug 6, 2018

@michaelkro that was my belief too. i don't think we show notifications when individual tasks complete; only when a plan (request) completes. although...that might be a nice feature to add, just not in this PR.

@AparnaKarve
Copy link
Contributor

Somehow it made sense to me to display notifications for individual tasks especially since we are in the Plan Detail page.

you could be viewing the details page for migration plan 1 and when migration plan 2 completes/fails, the notification would appear.

This is also a good addition and I can look into that in a separate PR.

@michaelkro
Copy link
Contributor

ok, awesome!

@AparnaKarve
Copy link
Contributor

you could be viewing the details page for migration plan 1 and when migration plan 2 completes/fails, the notification would appear.

@michaelkro I am planning on working on this next, although, this would involve bigger changes which I think should not go in gaprindashvili, just to be on the safer side.

@michaelkro
Copy link
Contributor

definitely agree @AparnaKarve. I also anticipate that to be a considerable effort and possibly an opportunity to streamline our polling.

We should create a separate issue for that, or create one for #543 and keep this one open. Whichever you prefer

michaelkro added a commit that referenced this issue Aug 8, 2018
@michaelkro
Merge pull request #543 from AparnaKarve/display_notifications_in_pla…
e24ed66 
…n_detail_page

[#265] Display successful/unsuccessful migration notifications in Plan detail page for in-progress->just completed tasks
@AparnaKarve
Copy link
Contributor

Re-opening this issue since the part mentioned in #265 (comment) is still pending

@AparnaKarve AparnaKarve reopened this Aug 8, 2018
simaishi pushed a commit that referenced this issue Aug 9, 2018
@michaelkro @simaishi
Merge pull request #543 from AparnaKarve/display_notifications_in_pla…
d3f215f 
…n_detail_page

[#265] Display successful/unsuccessful migration notifications in Plan detail page for in-progress->just completed tasks
(cherry picked from commit e24ed66)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1614060
@AparnaKarve
Copy link
Contributor

It seems more efficient to add this notification from the backend.
currently looking into implementing this via the backend automate code.

@AparnaKarve AparnaKarve mentioned this issue Aug 16, 2018
Closed
This was referenced Sep 21, 2018
Closed
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AparnaKarve AparnaKarve

Labels
enhancement Sprint 12
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mturley @AparnaKarve @priley86 @michaelkro @vconzola