This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
[#265] Display successful/unsuccessful migration notifications in Plan detail page for in-progress->just completed tasks #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AparnaKarve
changed the title
|
Not due to this PR, but as a side note, seeing the two notification systems starting to clash
|
AllenBW
approved these changes
Aug 8, 2018
There was a problem hiding this comment.
Code reads 🆗 to me! Nicely done @AparnaKarve The notification collision is a curious challenge to tackle... but not something I believe falls within the scope of this work 🤔 (simply because yeah, collisions could happen before this) (but also yeah its a good catch, to seeee emmmm)
michaelkro
approved these changes
Aug 8, 2018
simaishi
pushed a commit
that referenced
this pull request
Aug 9, 2018
…n_detail_page [#265] Display successful/unsuccessful migration notifications in Plan detail page for in-progress->just completed tasks (cherry picked from commit e24ed66) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1614060
|
Gaprindashvili backport details: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Plan Detail page will now display notifications for every
in-progress->just completedMigration task as shown below -After re-doing the logic for this task at least twice, I think what I have now is the simplest possible design that seems to work.
Fixes #265
https://bugzilla.redhat.com/show_bug.cgi?id=1614013