Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

User can cancel a migration in progress #370

Closed
serenamarie125 opened this issue Jun 1, 2018 · 16 comments
Closed

User can cancel a migration in progress #370

serenamarie125 opened this issue Jun 1, 2018 · 16 comments

Comments

@serenamarie125
Copy link

User can cancel a migration. Need to finalize the requirements here:

  • is cancel action only enabled/available for migrations in progress
  • cancel confirmation should be shown
@serenamarie125 serenamarie125 changed the title User can cancel a migration User can cancel a migration in progress Jun 1, 2018
@serenamarie125
Copy link
Author

@bzwei do we have existing API support for this?

@vconzola
Copy link

vconzola commented Jun 1, 2018

@serenamarie125 Where did this one come from? It's definitely good to have, I just don't see a Trello card for it. Another big requirements question is are we cancelling a whole plan or just individual migrations? Whole plan is more difficult because we need to take into account what we do with individual migrations that can be in different states - gets messy.

@serenamarie125
Copy link
Author

serenamarie125 commented Jun 1, 2018

@vconzola Brett said it was an ask for sprint 9

@bzwei
Copy link

bzwei commented Jun 2, 2018

We don't have existing API for canceling, nor do we have backend support. It will be a feature that requires a lot of effort.

@serenamarie125
Copy link
Author

Thanks @bzwei - FYI @bthurber if this is a need, can you chat with Greg B in priority? Taking off our sprint9 plans

@vconzola vconzola removed the p1 label Jun 8, 2018
@bthurber
Copy link

@JPrause
Copy link
Member

JPrause commented Jun 26, 2018

@miq-bot add_label blocker
Blocker to https://bugzilla.redhat.com/show_bug.cgi?id=1564257

@vconzola
Copy link

vconzola commented Jul 2, 2018

UX mockups are here.

@JPrause
Copy link
Member

JPrause commented Jul 3, 2018

Any update on this PR. We have an upcoming build on July 10

@priley86
Copy link
Member

priley86 commented Jul 3, 2018

Preliminary API spec for cancel from Fabien is here:
https://gist.github.com/fdupont-redhat/197fb71adf48482974b794a8a261de34

We can start prototyping this next...

@mturley mturley self-assigned this Jul 9, 2018
@mturley
Copy link
Contributor

mturley commented Jul 9, 2018

Starting on this while I wait for review on #467 to wrap up #399 .

@mturley
Copy link
Contributor

mturley commented Jul 13, 2018

My PR for this will go out today. I dropped the ball on finishing #399 this sprint because it needs another API call. But this I can have done today.

@mturley
Copy link
Contributor

mturley commented Jul 13, 2018

@JPrause sorry for the delay. The backend PR for this issue is now merged. The frontend PR will be up shortly and merged early next week (only because it's late Friday).

@bzwei
Copy link

bzwei commented Jul 16, 2018

@mturley please use this API call ManageIQ/manageiq-api#421

@mturley
Copy link
Contributor

mturley commented Jul 16, 2018

Sounds good, thanks @bzwei. This is my top priority.

@mturley
Copy link
Contributor

mturley commented Jul 20, 2018

This will now be done in #511, my original entire-plan cancel PR was, well, cancelled.

michaelkro added a commit that referenced this issue Jul 30, 2018
AparnaKarve pushed a commit to AparnaKarve/manageiq-v2v that referenced this issue Jul 31, 2018
…igrations

[ManageIQ#370] Cancel a migration's in-progress tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants