This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 42
Display the Transformation mapping info in the Plan list immediately when the list loads #696
Merged
michaelkro
merged 2 commits into
ManageIQ:master
from
AparnaKarve:nowait_for_transformationmappingname
Oct 11, 2018
Merged
Display the Transformation mapping info in the Plan list immediately when the list loads #696
michaelkro
merged 2 commits into
ManageIQ:master
from
AparnaKarve:nowait_for_transformationmappingname
Oct 11, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other related adjustments in reducer and lists
</ListView.InfoItem> | ||
), | ||
!plansMutatedWithMappingInfo && ( | ||
isMissingMapping && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
</ListView.InfoItem> | ||
), | ||
!plansMutatedWithMappingInfo && ( | ||
isMissingMapping && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
michaelkro
approved these changes
Oct 10, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic! 👍
simaishi
pushed a commit
that referenced
this pull request
Oct 12, 2018
…pingname Display the Transformation mapping info in the Plan list immediately when the list loads (cherry picked from commit 563ad4a)
Hammer backport details:
|
@AparnaKarve 4 out of 5 files conflict backporting to Gaprindashvili branch. Please create a separate PR. |
Backported to Gaprindashvili via #784 |
simaishi
added
gaprindashvili/backported
bug
and removed
gaprindashvili/conflict
labels
Nov 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #694
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1642611
The
Loading Infrastructure Mapping info...
status shown below won't be visible in the list anymore, and the Transformation mapping name associated with the plan would be loaded right away.Depends on PR - ManageIQ/manageiq#18070