Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Display the Transformation mapping info in the Plan list immediately when the list loads #696

Merged

Conversation

AparnaKarve
Copy link
Contributor

@AparnaKarve AparnaKarve commented Oct 8, 2018

Fixes #694
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1642611

The Loading Infrastructure Mapping info... status shown below won't be visible in the list anymore, and the Transformation mapping name associated with the plan would be loaded right away.

screen shot 2018-10-08 at 3 10 48 pm

Depends on PR - ManageIQ/manageiq#18070

</ListView.InfoItem>
),
!plansMutatedWithMappingInfo && (
isMissingMapping && (
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

</ListView.InfoItem>
),
!plansMutatedWithMappingInfo && (
isMissingMapping && (
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

Copy link
Contributor

@michaelkro michaelkro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic! 👍

@michaelkro michaelkro merged commit 563ad4a into ManageIQ:master Oct 11, 2018
@AparnaKarve AparnaKarve deleted the nowait_for_transformationmappingname branch October 11, 2018 16:40
simaishi pushed a commit that referenced this pull request Oct 12, 2018
…pingname

Display the Transformation mapping info in the Plan list immediately when the list loads

(cherry picked from commit 563ad4a)
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit f33d61e472d79a9ebd459125d01beaa20620f2cf
Author: Michael Ro <mikerodev@gmail.com>
Date:   Thu Oct 11 12:39:28 2018 -0400

    Merge pull request #696 from AparnaKarve/nowait_for_transformationmappingname
    
    Display the Transformation mapping info in the Plan list immediately when the list loads
    
    (cherry picked from commit 563ad4a8b1e3c49171faf3f8f6d594e6cc83e178)

@simaishi
Copy link
Contributor

simaishi commented Nov 6, 2018

@AparnaKarve 4 out of 5 files conflict backporting to Gaprindashvili branch. Please create a separate PR.

@AparnaKarve
Copy link
Contributor Author

@simaishi Created #784 for Gaprindashvili

@simaishi
Copy link
Contributor

Backported to Gaprindashvili via #784

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants