Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

[#857] Add skeleton for Conversion Hosts Settings components #858

Merged
merged 4 commits into from
Jan 25, 2019
Merged

[#857] Add skeleton for Conversion Hosts Settings components #858

merged 4 commits into from
Jan 25, 2019

Conversation

mturley
Copy link
Contributor

@mturley mturley commented Jan 24, 2019 •
edited
Loading

Part of the Conversion Hosts UI feature BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1693339

Closes #857.

This is a starting point for #854, #855 and #856.

To view the page, you'll need to enable it by changing the hideConversionHostSettings flag from true to false in Settings.js.

michaelkro
michaelkro reviewed Jan 25, 2019
View reviewed changes
Copy link
Contributor

@michaelkro michaelkro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might not be a bad idea to add some basic unit tests along with the scaffolding

@mturley
Copy link
Contributor Author

mturley commented Jan 25, 2019

@miq-bot add_reviewer @mzazrivec

@miq-bot
Copy link
Member

miq-bot commented Jan 25, 2019

@mturley 'mzazrivec' is an invalid reviewer, ignoring...

@mturley
Copy link
Contributor Author

mturley commented Jan 25, 2019

@michaelkro I started working on some unit tests for this and got distracted. Coming right up.

@mturley mturley force-pushed the 857-conversion-hosts-settings-skeleton branch from 0b5dd31 to 0defd96 Compare January 25, 2019 19:36
@miq-bot
Copy link
Member

miq-bot commented Jan 25, 2019

Checked commits mturley/manageiq-v2v@16c6790~...0defd96 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

michaelkro
michaelkro approved these changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@michaelkro michaelkro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@michaelkro michaelkro merged commit 6b37e54 into ManageIQ:master Jan 25, 2019
@mturley mturley deleted the 857-conversion-hosts-settings-skeleton branch January 28, 2019 13:49
@mturley mturley added bz Issues filed by QE or having a BZ and removed bugzilla needed labels Feb 27, 2019
@mturley mturley added v1.2 and removed v1.1 labels Mar 25, 2019
simaishi pushed a commit that referenced this pull request Apr 5, 2019
@michaelkro @simaishi
Merge pull request #858 from mturley/857-conversion-hosts-settings-sk…
8904746 
…eleton

[#857] Add skeleton for Conversion Hosts Settings components

(cherry picked from commit 6b37e54)

https://bugzilla.redhat.com/show_bug.cgi?id=1696423
@simaishi
Copy link
Contributor

simaishi commented Apr 5, 2019

Hammer backport details:

$ git log -1
commit 8904746e3589dae8b3dcee23dc398e4022d38d7f
Author: Michael Ro <mikerodev@gmail.com>
Date:   Fri Jan 25 16:11:30 2019 -0500

    Merge pull request #858 from mturley/857-conversion-hosts-settings-skeleton
    
    [#857] Add skeleton for Conversion Hosts Settings components
    
    (cherry picked from commit 6b37e5474f5abd1cbacfa99f7fbb1da379d4064f)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1696423

@mturley mturley mentioned this pull request Apr 25, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@codeclimate codeclimate[bot] codeclimate[bot] left review comments

@michaelkro michaelkro michaelkro approved these changes

Assignees
No one assigned
Labels
bz Issues filed by QE or having a BZ enhancement hammer/backported v1.2 z-stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mturley @miq-bot @simaishi @michaelkro