-
Notifications
You must be signed in to change notification settings - Fork 42
[Changelog] Update for Hammer-5 release #939
Conversation
@miq-bot add_label documentation |
Checked commit JPrause@6e4c343 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Some comments on commit JPrause@6e4c343 CHANGELOG.md
|
@miq-bot add_label hammer/yes |
@mturley as time permits, can you review/merge. |
@JPrause, many of these changes (all of the conversion host related changes) are not visible to the user until #922 is released (which enables that feature and was merged today). With the feature disabled, the additions have no effect and the fixes are for issues that were never exposed. Should we still include them here? |
Hmm. Looking at that PR922,...I see it has the label hammer/yes. However, it's ultimately your call about whether we merge this changelog. I can close this PR if you feel these shouldn't be exposed just yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll go ahead and merge this, we can always update it later.
@JPrause |
@JPrause please ping me when you have updated changelog PR for hammer-5 |
[Changelog] Update for Hammer-5 release (cherry picked from commit 2d61f88)
Hammer backport details:
|
[skip ci]