Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Fix inline edit buttons positioning by rendering as a child of an existing table cell #941

Merged

Conversation

mturley
Copy link
Contributor

@mturley mturley commented Apr 18, 2019

Replacement for #937.

Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1693382
Target CFME release: 5.10.4

YMEdQHY1ZV

@mturley mturley added bug bz Issues filed by QE or having a BZ labels Apr 18, 2019
@mturley mturley requested a review from mzazrivec April 18, 2019 14:55
@miq-bot
Copy link
Member

miq-bot commented Apr 18, 2019

Checked commits mturley/manageiq-v2v@3591a1c~...d2bb88b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@mzazrivec mzazrivec self-assigned this Apr 18, 2019
@mzazrivec mzazrivec merged commit fa53257 into ManageIQ:master Apr 18, 2019
@mturley mturley deleted the fix_inline_edit_buttons_positioning branch April 18, 2019 15:20
simaishi pushed a commit that referenced this pull request Apr 22, 2019
Fix inline edit buttons positioning by rendering as a child of an existing table cell

(cherry picked from commit fa53257)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1702084
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 7fa49e4c807cdd32d13c514669004e09c4ce9f45
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Thu Apr 18 17:15:24 2019 +0200

    Merge pull request #941 from mturley/fix_inline_edit_buttons_positioning
    
    Fix inline edit buttons positioning by rendering as a child of an existing table cell
    
    (cherry picked from commit fa532570d9e29d57b8b4eb58f78846d9fdd6f976)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1702084

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug bz Issues filed by QE or having a BZ hammer/backported v1.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants