ExtManagementSystem: Multiple columns called "Total Memory"

[himdel]

Base a report on Providers (any kind other than performance), and in Available Fields, there is "Total Memory" twice:

This is because one is total_memory and the other is aggregate_memory (both fields on ext_management_system) table.

> MiqExpression.model_details(ExtManagementSystem).select { |a,b| a =~ /Total Memory/ }
=> [["Provider : Total Memory", "ExtManagementSystem-aggregate_memory"], ["Provider : Total Memory", "ExtManagementSystem-total_memory"], ....]

Looks like this boils down to...

> MiqExpression.value2human('ExtManagementSystem-aggregate_memory')
"ExtManagementSystem-aggregate_memory"
=> "Provider : Total Memory"
> MiqExpression.value2human('ExtManagementSystem-total_memory')
"ExtManagementSystem-total_memory"
=> "Provider : Total Memory"

even

> MiqExpression.value2human('-aggregate_memory')
"-aggregate_memory"
=> " Total Memory"
> MiqExpression.value2human('-total_memory')
"-total_memory"
=> " Total Memory"

And that is ends up calling..

> Dictionary.gettext('total_memory', :type => :column, :notfound => :titleize)
=> "Total Memory"
> Dictionary.gettext('aggregate_memory', :type => :column, :notfound => :titleize)
=> "Total Memory"

Which is because

locale/en.yml
131:      aggregate_memory: Total Memory

(total_memory gets translated by that :notfound => :titleize fallback)

---

I guess these 2 fields (total_memory and aggregate_memory) should have distinct descriptions, but I don't know enough about the 2 fields to be able to tell the difference.

[djberg96]

I'm guessing this is a vmware thing:

https://www.vmware.com/support/developer/converter-sdk/conv51_apireference/memory_counters.html

Memory Total = Aggregate host machine memory - (VMkernel memory + Service Console memory + other service memory)

Then again maybe I'm way off. Can someone confirm?

[miq-bot]

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

[chessbyte]

@agrare can you chime in on this?

[agrare]

Actually I dont' think this is VMware specific, I think it is just duplicated

virtual_aggregate :total_memory, :hosts, :sum, :ram_size from ext_management_system.rb +231

And

def aggregate_memory(targets = nil)
  aggregate_hardware(:hosts, :memory_mb, targets)
end

From mixins/aggregation_mixin/methods.rb +17

So the only difference is one uses hosts.ram_size and one uses hosts.hardware.memory_mb. And ram_size is defined as hardware.memory_mb here. Therefore they are identical Q.E.D. :)

[himdel]

Makes sense, thanks :)

Still, having 2 identical entries in the report menu is suboptimal (even if they do the same thing), any chance we could get rid of one of those attributes?

[agrare]

Yes absolutely, working on that now

[agrare]

cc @kbrock

[kbrock]

dropping the delegate makes the most sense
ASSUMING that we update the reports to act accordingly

[miq-bot]

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the traige process documentation.

[gtanzillo]

ping @kbrock

[kbrock]

going forward with this:

introducing a hide_attribute that stores attributes in hidden_attributes. will also tie this into deprecate_attributes.

This will be used by MiqExpression.model_details and api: options_serializer.rb
for ideas on other places, grep for "attribute_names"