introduce User.lower_userid to remove some arel across a few repos

[kbrock]

I noticed a few lowercase comparisons for userid and a lookup by userid method

this allows us to just use active record where instead of the arel junk.

# before a
    where(arel_table.grouping(Arel::Nodes::NamedFunction.new("LOWER", [arel_attribute(:userid)]).eq(userid.downcase)))
before b
    where('lower(userid) = ?', userid.downcase)
# after
    where(:lower_userid => userid.downcase)

I would prefer if we used this instead of lookup_by_name() but want a second opinion on that one before moving forward. specifically the in region filter.

this is developer focused

[Fryguy]

Only thing I don't like about this is that it's now exposed to reporting.

[kbrock]

we need to come up with a way to hide attributes from reporting and from the api
This is also useful when we want to deprecate a fields. Have them work but not show up in the drop downs/documentation

I have had an idea mulling in my head for a while, but never know if this is viable or not - due to the complexity of add ing a concept that isn't really in rails at this time. attributes and hidden_attributes kinda like methods (privatet_methods) and public_methods?

[Fryguy]

I like the public/private designation idea. What if we just literally make them private, then in reporting, as we enumerate the methods we only take public virtual methods?

private

virtual_attribute :lower_userid, :string, :arel => ->(t) { t.grouping(t[:userid].lower) }

and/or

private virtual_attribute :lower_userid, :string, :arel => ->(t) { t.grouping(t[:userid].lower) }

[kbrock]

If we are using send to call these parameters, then that will require changes in using them
but when we are constructing the api or the drop down, we can look at them.

Nice to not introduce any new metadata

I do wonder how this will work if we use the class when it hasn't been used yet. the attributes may not be defined yet.

will look into this

[kbrock]

wipping until we find a good way to hide attributes in the api and report builder

[kbrock]

status: will hide this attribute using #20664
still waiting on that going through

[kbrock]

updated to use hide_attribute so it is not exposed in the api (this is now part of the core)
un-wipped

[miq-bot]

Checked commits kbrock/manageiq@c30555a~...668e834 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
4 files checked, 0 offenses detected
Everything looks fine. ⭐

[NickLaMuro]

Looks fine to me. Seems like Jason's concern was addressed, so I think this is good to go.

Sidenote: I think lower_* reads a little weird, but seems like it is derived from the posgresql string function, so I don't think it is worth trying to do an exercise of trying to find a better name, so just leave it.