Replaced validate_reset methods by supports_reset #11625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label wip |
|
<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush. |
gauravaradhye
changed the title
|
@miq-bot remove_label wip |
|
Checked commit gauravaradhye@816cf6f with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
@durandom Can you please check this! |
|
@miq-bot add_label euwe/no |
|
@gauravaradhye looks great, I feel you are getting the hang of it 😄 @agrare can you have a final look and merge? |
|
Looks good 👍 |
This was referenced Mar 9, 2017
kbrock
added a commit
to kbrock/manageiq
that referenced
this pull request
May 12, 2022
by the time this was added, the buttons looked at supports. there was a bug in HostFeatureButtonWithDisable and instead of having that button support both availability mixin and supports feature mixin this method was added. this commit only works because we're changing the buttons to only call supports? refs: remove validate_reset: ManageIQ#11625 added back: ManageIQ#12324 (guessing we should have changed the button instead) changes to availability mixin in generic button: manageiq-ui-classic a85cfb1
kbrock
added a commit
to kbrock/manageiq
that referenced
this pull request
May 13, 2022
by the time this was added, the buttons looked at supports. there was a bug in HostFeatureButtonWithDisable and instead of having that button support both availability mixin and supports feature mixin this method was added. this commit only works because we're changing the buttons to only call supports? refs: remove validate_reset: ManageIQ#11625 added back: ManageIQ#12324 (guessing we should have changed the button instead) changes to availability mixin in generic button: manageiq-ui-classic a85cfb1
iv1111
pushed a commit
to iv1111/manageiq
that referenced
this pull request
Jun 28, 2022
by the time this was added, the buttons looked at supports. there was a bug in HostFeatureButtonWithDisable and instead of having that button support both availability mixin and supports feature mixin this method was added. this commit only works because we're changing the buttons to only call supports? refs: remove validate_reset: ManageIQ#11625 added back: ManageIQ#12324 (guessing we should have changed the button instead) changes to availability mixin in generic button: manageiq-ui-classic a85cfb1
GilbertCherrie
pushed a commit
to GilbertCherrie/manageiq
that referenced
this pull request
Jul 7, 2023
by the time this was added, the buttons looked at supports. there was a bug in HostFeatureButtonWithDisable and instead of having that button support both availability mixin and supports feature mixin this method was added. this commit only works because we're changing the buttons to only call supports? refs: remove validate_reset: ManageIQ#11625 added back: ManageIQ#12324 (guessing we should have changed the button instead) changes to availability mixin in generic button: manageiq-ui-classic a85cfb1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced all instanced of validate_reset method by supports_reset in order to make use supportsFeatureMixin.
It's not yet mergeable because it has changes of another commit which is not pushed in yet.