Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCVMM - Enable VM reset functionality #14123

Merged
merged 1 commit into from
Mar 1, 2017
Merged

SCVMM - Enable VM reset functionality #14123

merged 1 commit into from
Mar 1, 2017

Conversation

bronaghs
Copy link

@bronaghs bronaghs commented Mar 1, 2017

Although the SCVMM VM reset method is in place and working correctly, supports :reset was missing, this resulted in the the "Power/reset" menu item being excluded from the VM summary page.

https://bugzilla.redhat.com/show_bug.cgi?id=1392608

@bronaghs
Copy link
Author

bronaghs commented Mar 1, 2017

@miq-bot assign @agrare
@miq-bot add_label providers/scvmm
@miq-bot add_label bug

@miq-bot
Copy link
Member

miq-bot commented Mar 1, 2017

@bronaghs Cannot apply the following label because they are not recognized: providers/scvmm

@miq-bot miq-bot added the bug label Mar 1, 2017
@miq-bot
Copy link
Member

miq-bot commented Mar 1, 2017

Checked commit bronaghs@1104394 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🏆

@agrare
Copy link
Member

agrare commented Mar 1, 2017

LGTM 👍

@agrare agrare merged commit 4e1ed16 into ManageIQ:master Mar 1, 2017
@agrare agrare added this to the Sprint 56 Ending Mar 13, 2017 milestone Mar 1, 2017
@bronaghs bronaghs deleted the scvmm_vm_reset_bz_1392608 branch March 1, 2017 19:44
@agrare agrare added the euwe/yes label Mar 1, 2017
simaishi pushed a commit that referenced this pull request Mar 9, 2017
@agrare @simaishi
Merge pull request #14123 from bronaghs/scvmm_vm_reset_bz_1392608
c6748bc 
SCVMM - Enable VM reset functionality
(cherry picked from commit 4e1ed16)

https://bugzilla.redhat.com/show_bug.cgi?id=1428509
@simaishi
Copy link
Contributor

simaishi commented Mar 9, 2017

Euwe backport details:

 $ git log -1
commit c6748bc669469c68397db153af5df0ab078f683a
Author: Adam Grare <agrare@redhat.com>
Date:   Wed Mar 1 14:40:20 2017 -0500

    Merge pull request #14123 from bronaghs/scvmm_vm_reset_bz_1392608
    
    SCVMM - Enable VM reset functionality
    (cherry picked from commit 4e1ed161bbe0b9805c1d5517a35e570a3cd78a66)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1428509

@agrare
Copy link
Member

agrare commented Mar 9, 2017 •
edited
Loading

supports :reset was added to the SupportsFeatureMixin by #11625 which is marked euwe/no

Looks like for euwe we need to add a def validate_reset to the VM

@simaishi
Copy link
Contributor

simaishi commented Mar 9, 2017 •
edited
Loading

@agrare Thanks, I was about to ping you and/or @bronaghs for the Travis failure (https://travis-ci.org/ManageIQ/manageiq/jobs/209476204) :)

@agrare agrare mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@agrare agrare

Labels
bug euwe/backported providers/infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bronaghs @miq-bot @agrare @simaishi @Fryguy