Added container components for service model. #12863

kevensen · 2016-11-25T19:46:49Z

OpenShift (and theoretically other container platforms) objects should be treated as first class citizens in the Automate Service Model in ManageIQ. This will enable customized workflows using these objects.

This pull request only adds code that allows one to Read the objects. Future work will be made to allow an automate workflow to Create, Update, and Delete the objects.

https://bugzilla.redhat.com/show_bug.cgi?id=1378190

mkanoor · 2016-11-30T20:07:59Z

lib/miq_automation_engine/service_models/miq_ae_service_container.rb

@@ -0,0 +1,4 @@
+module MiqAeMethodService
+ class MiqAeServiceContainer < MiqAeServiceModelBase


@kevensen
From the service model are you planning on exposing its relationships or just the attributes.
With the current implementation only the attributes are going to be exposed and not any relationships.
https://github.com/ManageIQ/manageiq/blob/master/lib/miq_automation_engine/service_models/miq_ae_service_host.rb#L6 shows how we expose relationships

@mkanoor I want to expose some of the relationships. Thank you for the tip. I'll update the pull request in the next day or two. Or would you rather me close this request and open a new one?

@kevensen
You can just add new commits to this PR

mkanoor · 2016-12-02T15:21:01Z

@kevensen
Also please add specs for the service model expose associations. This ensures that we only expose the associations that are valid.
https://github.com/ManageIQ/manageiq/blob/master/spec/lib/miq_automation_engine/service_methods/miq_ae_service_user_spec.rb
has a sample

kevensen · 2016-12-04T02:05:53Z

@mkanoor - I've looked at the specs for the service model exposed associations. Please forgive me that my Ruby is a little weak. Are these specs checked at runtime? Or are these like unit tests?

mkanoor · 2016-12-05T14:49:57Z

@kevensen
They are like unit tests, these just validate that the required functions are exposed in case someone later tries to remove one of the exposed methods.

kevensen · 2016-12-08T20:55:42Z

@mkanoor - I've completed the service model, associations, and specs. At your convenience please review. I look forward to and appreciate any feedback you have.

mkanoor · 2016-12-13T14:19:54Z

app/models/container_component_status.rb

@@ -1,3 +1,9 @@
 class ContainerComponentStatus < ApplicationRecord
 belongs_to :ext_management_system, :foreign_key => "ems_id"
+
+ virtual_column :name, :type => :string


@blomquisg
Hi Greg can you have someone from provider team review the app/models changes.

mkanoor · 2017-01-13T20:24:12Z

@kevensen
Can you please move the app/model changes do a different PR since this PR is just about service models.

https://bugzilla.redhat.com/show_bug.cgi?id=1378190

miq-bot · 2017-01-14T00:17:19Z

Checked commit kevensen@78cfe13 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
45 files checked, 0 offenses detected
Everything looks good. 👍

kevensen · 2017-01-14T00:44:55Z

@mkanoor Certainly. I've reverted those files back.

gmcculloug · 2017-04-03T15:32:23Z

@kevensen Is this valid for back-port to the Euwe branch? Please label euwe/yes if so. If this cannot be back-ported let's discuss and determine what needs to be pulled back to fix https://bugzilla.redhat.com/show_bug.cgi?id=1437128.

kevensen · 2017-04-04T00:35:02Z

@gmcculloug I just ran the test suite against these components in the euwe branch and it looked fine. So, yes, I believe this is valid for a back-port. I'd be happy to change the label, but not being a member I don't think I have the permission to do so.

gmcculloug · 2017-04-04T00:41:23Z

@kevensen I set the flag but it is also available for others through the miq-bot. See documentation here: https://github.com/ManageIQ/miq_bot

moolitayer · 2017-04-04T11:22:37Z

Still waiting for bz creation but we asked https://bugzilla.redhat.com/show_bug.cgi?id=1437128 marked as a blocker for euwe.

@miq-bot add_label blocker

moolitayer · 2017-04-04T13:54:01Z

@gmcculloug I'm looking into unit testing the automate part in container SSA (check policy prevent). Do you have any pointers (other tests that run an automate worker?)

Added container components for service model. (cherry picked from commit 3650d79) https://bugzilla.redhat.com/show_bug.cgi?id=1437128

simaishi · 2017-04-04T16:20:52Z

Euwe backport details:

$ git log -1
commit dfbb9d9d2ac46578cf9273fa398da5da8f408bf3
Author: Madhu Kanoor <mkanoor@redhat.com>
Date:   Mon Jan 16 10:25:26 2017 -0500

    Merge pull request #12863 from kevensen/service_model_containers
    
    Added container components for service model.
    (cherry picked from commit 3650d79e226f6501c397dbc9bf6e785d7561bbfb)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1437128

pemcg · 2017-05-25T15:21:44Z

It would be great if these service models could support custom attributes so that we could label the objects from automate

gmcculloug · 2017-05-25T15:31:56Z

@pemcg @kevensen If the active_record models support custom_attributes there is a service_model mixin for adding the accessor methods:

MiqAeServiceCustomAttributeMixin
https://github.com/ManageIQ/manageiq-automation_engine/blob/master/lib/miq_automation_engine/service_models/mixins/miq_ae_service_custom_attribute_mixin.rb

Example Usage:
https://github.com/ManageIQ/manageiq-automation_engine/blob/master/lib/miq_automation_engine/service_models/miq_ae_service_vm_or_template.rb#L9

kevensen · 2017-05-25T17:16:42Z

@pemcg @gmcculloug For a frame of reference, can you please remind me what would be a custom attribute for a VM? I think it would be a good idea to tie these to labels on container resources.

pemcg · 2017-05-25T17:33:45Z

Custom attributes allow users to add their own key/value text pairs to objects. A typical example might be a Configuration ID from a CMDB, or a 'status' text string. It's useful to be able to define them from automate using the custom_set method even if they are not necessarily visible in the WebUI.

This chapter https://pemcg.gitbooks.io/mastering-automation-in-cloudforms-4-2-and-manage/content/working_with_virtual_machines/chapter.html describes how to set custom attributes on a VM if it helps.

chessbyte added automate enhancement providers/containers labels Nov 28, 2016

chessbyte assigned mkanoor Nov 28, 2016

mkanoor reviewed Nov 30, 2016

View reviewed changes

mkanoor reviewed Dec 13, 2016

View reviewed changes

Added container components for service model.

78cfe13

https://bugzilla.redhat.com/show_bug.cgi?id=1378190

mkanoor approved these changes Jan 16, 2017

View reviewed changes

mkanoor merged commit 3650d79 into ManageIQ:master Jan 16, 2017

mkanoor added this to the Sprint 52 Ending Jan 16, 2017 milestone Jan 16, 2017

supernoodz mentioned this pull request Jan 31, 2017

[WIP] Expose container projects in the service model #12654

Closed

supernoodz mentioned this pull request Mar 13, 2017

Extend container service model #14233

Merged

gmcculloug added the euwe/yes label Apr 4, 2017

miq-bot added the blocker label Apr 4, 2017

simaishi pushed a commit that referenced this pull request Apr 4, 2017

Merge pull request #12863 from kevensen/service_model_containers

dfbb9d9

Added container components for service model. (cherry picked from commit 3650d79) https://bugzilla.redhat.com/show_bug.cgi?id=1437128

simaishi added euwe/backported and removed euwe/yes labels Apr 4, 2017

kevensen mentioned this pull request Apr 13, 2017

[EUWE] Added ability to connect to the container provider. https://bugzilla.… #14688

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added container components for service model. #12863

Added container components for service model. #12863

kevensen commented Nov 25, 2016

mkanoor Nov 30, 2016

kevensen Dec 1, 2016

mkanoor Dec 1, 2016

mkanoor commented Dec 2, 2016

kevensen commented Dec 4, 2016

mkanoor commented Dec 5, 2016

kevensen commented Dec 8, 2016

mkanoor Dec 13, 2016

mkanoor commented Jan 13, 2017

miq-bot commented Jan 14, 2017

kevensen commented Jan 14, 2017

gmcculloug commented Apr 3, 2017

kevensen commented Apr 4, 2017

gmcculloug commented Apr 4, 2017

moolitayer commented Apr 4, 2017

moolitayer commented Apr 4, 2017

simaishi commented Apr 4, 2017

pemcg commented May 25, 2017

gmcculloug commented May 25, 2017

kevensen commented May 25, 2017

pemcg commented May 25, 2017

		@@ -0,0 +1,4 @@
		module MiqAeMethodService
		class MiqAeServiceContainer < MiqAeServiceModelBase

Added container components for service model. #12863

Added container components for service model. #12863

Conversation

kevensen commented Nov 25, 2016

mkanoor Nov 30, 2016

Choose a reason for hiding this comment

kevensen Dec 1, 2016

Choose a reason for hiding this comment

mkanoor Dec 1, 2016

Choose a reason for hiding this comment

mkanoor commented Dec 2, 2016

kevensen commented Dec 4, 2016

mkanoor commented Dec 5, 2016

kevensen commented Dec 8, 2016

mkanoor Dec 13, 2016

Choose a reason for hiding this comment

mkanoor commented Jan 13, 2017

miq-bot commented Jan 14, 2017

kevensen commented Jan 14, 2017

gmcculloug commented Apr 3, 2017

kevensen commented Apr 4, 2017

gmcculloug commented Apr 4, 2017

moolitayer commented Apr 4, 2017

moolitayer commented Apr 4, 2017

simaishi commented Apr 4, 2017

pemcg commented May 25, 2017

gmcculloug commented May 25, 2017

kevensen commented May 25, 2017

pemcg commented May 25, 2017