Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EUWE] Added ability to connect to the container provider. https://bugzilla.… #14688

Closed
wants to merge 1 commit into from

Conversation

kevensen
Copy link
Contributor

@kevensen kevensen commented Apr 7, 2017

…redhat.com/show_bug.cgi?id=1378190

With container objects added to the service model, it would be great to have the ability to manipulate objects back in the provider from the service model. This pull request accomplishes that by expose the "connect" method.

Links

@miq-bot miq-bot changed the title Added ability to connect to the container provider. https://bugzilla.… [EUWE] Added ability to connect to the container provider. https://bugzilla.… Apr 7, 2017
@miq-bot
Copy link
Member

miq-bot commented Apr 7, 2017

Checked commit kevensen@e5de03b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🍰

@simaishi
Copy link
Contributor

@kevensen is this an Euwe only issue? If no, please reference a PR for 'master' branch.

@kevensen
Copy link
Contributor Author

@simaishi - I'd certainly prefer to. However it looks like the container service model from #12863 is no longer in the master branch.

@kevensen
Copy link
Contributor Author

@simaishi - I take that back. The container model is still but the container provider modules are gone.

@gmcculloug
Copy link
Member

Hey @kevensen - Empty service models were removed upstream now that we dynamically create them as per PR #14465.

If you want to expose additional properties of a model the service model file needs to be recreated and modified. This will need to happen upstream first so I will be closing this PR.

Having said that we do not expose the connect method on any provider directly to automate. I would suggest opening a PR or git issue upstream where we can discuss your use cases and see if there is some other way to accomplish what you are trying to do.

@gmcculloug gmcculloug closed this Apr 13, 2017
kevensen pushed a commit to kevensen/manageiq that referenced this pull request Apr 13, 2017
@kevensen
Copy link
Contributor Author

@gmcculloug - Understood. I've opened #14771.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants