Chargeback no longer depend on MetricRollup #13221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful in world without metric_rollups.
Just pass the consumption object. Note that we still depend on metric_rollup_record, but we are getting close for not needing it.
And delegate resource and timestamp to first_metric_rollup_record
isimluk
force-pushed
the
consumption-history
branch
from
623c362
to
77d8788
Compare
isimluk
force-pushed
the
consumption-history
branch
from
4c7aa62
to
0ac994e
Compare
|
Checked commits isimluk/manageiq@b234e2a~...0ac994e with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 app/models/chargeback/consumption_history.rb
app/models/chargeback_container_image.rb
|
This was referenced Dec 16, 2016
isimluk
changed the title
|
Backported to Euwe via #13419 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Extract MetricRollup manipulation into
ConsumptionandConsumptionHistoryclasses.Why
Needed for upcoming chargebacks without metric rollups.
Details
Previously, chargeback relied on existing metric_rollups and chargeback code was tightly bound to metric_rollup class. In future, we want to charge for VMs that do not have metric_rollups assigned.
Thus, we need to break the bound between chargeback code and metric_rollups. We need chargeback code to depend only on
Consumptionclass fetching this class fromConsumptionHistory. Then we can changeConsumptionto operate over VMs without metric_rollups./cc @lpichler -- Thanks for consultation, sir!
@miq-bot add_label chargeback, refactoring, euwe/no
@miq-bot assign @gtanzillo