Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Amazon storage manager AE models #13550

Closed
wants to merge 1 commit into from
Closed

Rename Amazon storage manager AE models #13550

wants to merge 1 commit into from

Conversation

gberginc
Copy link
Contributor

This patch accompanies the renaiming of Amazon BlockStorageManager
into StorageManager::Ebs. It merely renames the corresponding
automation models.

@miq-bot label providers/amazon,providers/storage,automate/model,wip

@gberginc
Rename Amazon storage manager AE models
15957e3 
This patch accompanies the renaiming of Amazon `BlockStorageManager`
into `StorageManager::Ebs`. It merely renames the corresponding
automation models.

Signed-off-by: Gregor Berginc <gregor.berginc@xlab.si>
@miq-bot
Copy link
Member

miq-bot commented Jan 17, 2017

@gberginc unrecognized command 'label', ignoring...

Accepted commands are: add_label, remove_label, rm_label, assign, set_milestone

@gberginc gberginc mentioned this pull request Jan 17, 2017
Merged
@miq-bot
Copy link
Member

miq-bot commented Jan 17, 2017

Checked commit xlab-si@15957e3 with ruby 2.2.6, rubocop 0.46.0, and haml-lint 0.19.0
3 files checked, 0 offenses detected
Everything looks good. ⭐

@gberginc gberginc changed the title [WIP] Rename Amazon storage manager AE models Rename Amazon storage manager AE models Jan 18, 2017
@gberginc
Copy link
Contributor Author

This PR depends on ManageIQ/manageiq-providers-amazon#107, which has received the first "ok". Please review this change as well.

@miq-bot remove_label wip

@miq-bot miq-bot removed the wip label Jan 18, 2017
@gberginc gberginc closed this Jan 18, 2017
@gberginc gberginc reopened this Jan 18, 2017
@roliveri
Copy link
Member

@blomquisg It looks like this PR has a codependency with #13549, so they both need to be merged before their tests will pass. Should we just merge them while red to see if the result is green?

@gberginc
Copy link
Contributor Author

@roliveri with yesterday's patches we did it like you suggested. Alternatively, I can make a PR with all the changes in the currently opened PRs to make sure we are safe.

@roliveri
Copy link
Member

@gberginc Given that the remaining 3 PRs are in the same repo, combining them into a single PR might be the safer way to go. Unless anyone has any objections to that.

@gberginc
Copy link
Contributor Author

@roliveri ok, let's see if this will work; I'll send you a message once I have the new PR ready

@gberginc gberginc mentioned this pull request Jan 18, 2017
Merged
@gberginc
Copy link
Contributor Author

Closing in favour of #13569

@roliveri in my local environment, both of the failing tests were passing so hopefully they will in the above PR as well :-D

@gberginc gberginc closed this Jan 18, 2017
@tadeboro tadeboro deleted the amazon/rename_ebs_automate branch March 30, 2018 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
providers/cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gberginc @miq-bot @roliveri @blomquisg @Fryguy @chessbyte