Rename Amazon EBS storage manager #13569
Conversation
This patch accompanies the renaiming of Amazon `BlockStorageManager` into `StorageManager::Ebs`. It merely renames the corresponding automation models. Signed-off-by: Gregor Berginc <gregor.berginc@xlab.si>
The initial version of the Amazon block storage manager used the name `ec2_block_storage` which has now been replaced with `ec2_ebs_storage` to make it more explicit. This patch fixes the `ext_management_system` spec and the corresponding tamplate to use the new name. Signed-off-by: Gregor Berginc <gregor.berginc@xlab.si>
Specification of this class is required for MiQ to be aware of the new refresh worker supporting Amazon EBS block storage refresh parser. Signed-off-by: Gregor Berginc <gregor.berginc@xlab.si>
gberginc
changed the title
|
Hey @gberginc, @imtayadeway beat you by a few minutes on this one :) #13568 |
|
@agrare @imtayadeway #13568 does not contain the PR registering the worker class (#13457). I'll check if you decide to merge the other one instead of this and reopen #13457 if necessary. |
|
Checked commits xlab-si/manageiq@8a6ec1d~...28f4bf2 with ruby 2.2.6, rubocop 0.46.0, and haml-lint 0.19.0 |
|
@roliveri I just rebased it in my local env, but the same test is failing. To me it looks like other PRs are also failing for the same error (along the one this PR is trying to resolve). |
|
@gberginc Yep, it seems Master is broken for some unrelated reason. I vote for merging this PR (while red) instead of #13568. @Fryguy @blomquisg - Does that sound OK? |
ManageIQ/manageiq-providers-amazon#107 renames the Amazon block storage manager from
ManageIQ::Providers::Amazon::BlockStorageManagertoManageIQ::Providers::Amazon::StorageManager::Ebs. This patch fixes the dependencies in the main repository that were broken by this change.It replaces these PRs:
@miq-bot providers/amazon,providers/storage
@miq-bot assign @roliveri