Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cid constant namespacing in the API #13671

Merged
merged 2 commits into from
Jan 27, 2017
Merged

Fix cid constant namespacing in the API #13671

merged 2 commits into from
Jan 27, 2017

Commits on Jan 27, 2017

  1. Qualify CID_OR_ID_MATCHER constant 

    Modules can use other modules' methods if included together in the same
class, but they can't reference another module's constants
unqualified. Thus, when referencing the `CID_OR_ID_MATCHER` constant,
which is included into `Api::BaseController` via `CompressedIds`, when
used in a module such as `Api::BaseController::Parser` it must be
qualified as `BaseController::CID_OR_ID_MATCHER`.
    @imtayadeway
    imtayadeway committed Jan 27, 2017
    Configuration menu
    Copy the full SHA
    5d9f8d7 View commit details
    Browse the repository at this point in the history

  2. No need to re-include CompressedIds

    @imtayadeway
    imtayadeway committed Jan 27, 2017
    Configuration menu
    Copy the full SHA
    522366b View commit details
    Browse the repository at this point in the history