Fix cid constant namespacing in the API

[imtayadeway]

Does a few things:

1. Qualify CID_OR_ID_MATCHER constant

Modules can use other modules' methods if included together in the same
class, but they can't reference another module's constants
unqualified. Thus, when referencing the CID_OR_ID_MATCHER constant,
which is included into Api::BaseController via CompressedIds, when
used in a module such as Api::BaseController::Parser it must be
qualified as BaseController::CID_OR_ID_MATCHER.

2. Since the namespacing is fixed, we no longer need to re-include CompressedIds in Parser

3. One of the references to CID_OR_ID_MATCHER could be remove, because it is dead code, AFAICT. The intention was to parser a policy href if provided, but if so it will already have been parsed and converted to an id.

EDIT: I'll tackle (3) in an follow up

@abellotti can you double check my assumptions here? Also, I'd love to add a test for assigning/unassigning tags by href (as opposed to name/category) but I couldn't get anything to work. Could we look at this together if you want a test? Alternatively I can add one in a follow up.

[imtayadeway]

@miq-bot add-label api, bug
@miq-bot assign @abellotti

[jntullo]

@imtayadeway this looks great! I also spent a bit of time today trying to get a test for assigning/unassigning to work based off of this bug/my PR but couldn't - AFAICT parse_tag_from_href isn't getting called anywhere (which is probably how we missed this bug in the first place) because the initial request parses the ID from the href before it ever gets to that point in the code. The bulk tag assign action (in #13581) has a different request format, which is why it shed light on this.

[imtayadeway]

@jntullo I had a strong suspicion this was so....I came to the same conclusion with the policy stuff. I went conservative with that change in an effort to unblock @abellotti today, but I no longer think this change is necessary, so perhaps we can look at this closer tomorrow?

[abellotti]

Just tried this on master and it works:

POST /api/vms/166/tags
{
  "action" : "assign",
  "resources" : [
     { "href" : "http://localhost:3000/api/tags/5" }
  ]
}

[abellotti]

why is this removed ?

[imtayadeway]

☝️ #13671 (comment) item number 3. Happy to be proved wrong, but I did some testing on this endpoint and couldn't get at it

[abellotti]

yep, you're right. handled already earlier via parse_id. Thanks.

[abellotti]

it's still included by base_controller/parser/request_adapter.rb, we should only need it in base_controller.rb

[imtayadeway]

it's still included by base_controller/parser/request_adapter.rb, we should only need it in base_controller.rb

RequestAdapter is a class with its own scope, so it needs to have that module included there. Everything else is a module which gets included into BaseController 😄

[abellotti]

LGTM!! will merge when 🍏

[miq-bot]

Checked commits imtayadeway/manageiq@5d9f8d7~...522366b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks good. 🏆

[abellotti]

🎶