Remove dead href parsing paths #13684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If hrefs were supplied in the request body, they should have already been parsed by `BaseController#update_multiple_collections` and given to these methods as the id for the resource they represent. So these parts of the code should been unreachable, and can be replaced by an empty hash in the event that all other attempts to parse the resource at hand have failed. Follow up to ManageIQ#13671
|
Checked commit imtayadeway@207fd39 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
I think this is fine, manually tested with tags and profiles sub-collections. Can you verify we have good test coverage for both these sub-collections on both assign and unassign via href's ? If not extend as needed. Thanks. |
|
@abellotti we should be good WRT coverage - there are some holes in areas like what happens if assigning/unassigning a policy fails, etc.., but all things that are post-parsing |
|
Thanks @imtayadeway for checking. 🎵 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If hrefs were supplied in the request body, they should have already
been parsed by
BaseController#update_multiple_collectionsand given tothese methods as the id for the resource they represent. So these parts
of the code should been unreachable, and can be replaced by an empty
hash in the event that all other attempts to parse the resource at hand
have failed.
Follow up to #13671
@abellotti no rush on this, just wanted to make this PR so I don't forget about it.
@miq-bot add-label api, technical debt
@miq-bot assign @abellotti
/cc @jntullo
✂️ ✂️ ✂️