[EUWE] Remove disabling of 'instance_retire' button #14016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng of 'instance_retire' button
romanblanco
changed the title
|
@miq-bot add_label bug, ui @PanSpagetka or @vecerek can you review the fix, please? |
|
Checked commit romanblanco@7610fda with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Verified in UI, it works 👍 |
|
@romanblanco is there a 'master' PR for this? |
|
@simaishi No, it's not. Just this one, in |
|
@romanblanco would you mind referencing the PR that removed this from 'master'? |
|
@simaishi Actually, I've just noticed that the issue has been moved to I'll create PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaves the button "Set Retirement Date" enabled even for a retired instance
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1306471
Steps for Testing/QA
LifecycleSet Retirement Dateshould be enabled(see BZ ticket for more info)