Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove disabling of 'instance_retire' button #453

Merged
merged 1 commit into from
Feb 23, 2017

Conversation

romanblanco
Copy link
Member

@romanblanco romanblanco commented Feb 22, 2017

copy of the PR to Euwe: ManageIQ/manageiq#14016


Leaves the button "Set Retirement Date" enabled even for a retired instance

Links

https://bugzilla.redhat.com/show_bug.cgi?id=1306471

Steps for Testing/QA

  1. retire an instance
  2. go to that instance details page
  3. click Lifecycle
  4. button Set Retirement Date should be enabled

(see BZ ticket for more info)

/cc @simaishi

Parent issue: ManageIQ/manageiq#6259
Related issue: ManageIQ/manageiq#6554

@romanblanco
Copy link
Member Author

@vecerek or @PanSpagetka please review

@miq-bot
Copy link
Member

miq-bot commented Feb 22, 2017

Checked commit romanblanco@032a5a7 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 2 offenses detected

app/helpers/application_helper/toolbar/openstack_vm_cloud_center.rb

app/helpers/application_helper/toolbar/x_vm_cloud_center.rb

Copy link

@vecerek vecerek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@vecerek
Copy link

vecerek commented Feb 23, 2017

Checked the UI, I am still not able to retire an instance (with simulate_queue_worker running). After I click on the retire button, the process is initiated but the button won't get disabled. Same thing was happening when I was working on ManageIQ/manageiq#13076

@mzazrivec mzazrivec self-assigned this Feb 23, 2017
@mzazrivec mzazrivec added this to the Sprint 55 Ending Feb 27, 2017 milestone Feb 23, 2017
@mzazrivec mzazrivec merged commit 7e40253 into ManageIQ:master Feb 23, 2017
@romanblanco romanblanco deleted the instance_retire_button branch February 23, 2017 13:34
@romanblanco
Copy link
Member Author

@dclarizio I'm setting euwe/yes label because of this BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1427168

@miq-bot add_label euwe/yes

@simaishi
Copy link
Contributor

Backported to Euwe via ManageIQ/manageiq#14016

@romanblanco
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants