-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove disabling of 'instance_retire' button #453
Conversation
@vecerek or @PanSpagetka please review |
Checked commit romanblanco@032a5a7 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/helpers/application_helper/toolbar/openstack_vm_cloud_center.rb
app/helpers/application_helper/toolbar/x_vm_cloud_center.rb
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Checked the UI, I am still not able to retire an instance (with simulate_queue_worker running). After I click on the retire button, the process is initiated but the button won't get disabled. Same thing was happening when I was working on ManageIQ/manageiq#13076 |
@dclarizio I'm setting @miq-bot add_label euwe/yes |
Backported to Euwe via ManageIQ/manageiq#14016 |
@miq-bot add_label darga/yes |
copy of the PR to Euwe: ManageIQ/manageiq#14016
Leaves the button "Set Retirement Date" enabled even for a retired instance
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1306471
Steps for Testing/QA
Lifecycle
Set Retirement Date
should be enabled(see BZ ticket for more info)
/cc @simaishi
Parent issue: ManageIQ/manageiq#6259
Related issue: ManageIQ/manageiq#6554