Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbar refactoring: Instance buttons #13076

Merged
merged 6 commits into from
Dec 20, 2016
Merged

Toolbar refactoring: Instance buttons #13076

merged 6 commits into from
Dec 20, 2016

Conversation

vecerek
Copy link

@vecerek vecerek commented Dec 9, 2016 •
edited
Loading

Created separate classes for the instance_ prefixed buttons in #hide_button?. I couldn't manage to test the instance_retire buttons in UI because an instance could not be made retired.
Nothing happens after this message appears:
instance_retire_successful

Toolbar button id Toolbar buttons class created
instance_check_compliance, instance_compare InstanceCheckCompare < Basic
instance_retire, instance_retire_now InstanceRetire < Basic

How to review

instance_check_compliance

  1. Create a Compliance Policy in Control -> Explorer -> Policies tree -> Vm and Compliance Policies subtree -> Configuration -> Add a new VM and Instance Compliance Policy
  2. Assign the Policy to a Policy profile in Control -> Explorer -> Policy Profile tree -> Select a policy profile -> Configuration -> Edit this Policy Profile
  3. Assign the Policy profile to an Openstack Cloud Instance in Compute -> Clouds -> Instances -> Select an openstack instance -> Policy -> Manage policies -> Select and add the policy profile from the previous step
  4. Policy -> Check Compliance of Last Known Configuration should be enabled.

instance_compare

  1. Compute -> Clouds -> Instances -> Select the Openstack provider
  2. Mark two checkboxes there and the button should be visible under the Configuration select button.

instance_retire, instance_retire_now

I was not able to make the instances retire.

Links

Parent issue: #6259
Related issue: #6554
Pivotal Tracker: https://www.pivotaltracker.com/story/show/135535379

@chessbyte chessbyte added the ui label Dec 9, 2016
@vecerek vecerek force-pushed the toolbar_refactoring__instance_buttons branch from 2cb5583 to 91b6e93 Compare December 12, 2016 17:00
@vecerek
Copy link
Author

vecerek commented Dec 12, 2016

Waiting for #13052

@vecerek vecerek force-pushed the toolbar_refactoring__instance_buttons branch from 91b6e93 to dbd9ad6 Compare December 14, 2016 14:26
@vecerek
Copy link
Author

vecerek commented Dec 14, 2016

@PanSpagetka @jzigmund could you review, pls?

@miq-bot
Copy link
Member

miq-bot commented Dec 15, 2016

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

@vecerek vecerek force-pushed the toolbar_refactoring__instance_buttons branch from dbd9ad6 to 3c6bfd4 Compare December 15, 2016 17:17
@miq-bot
Copy link
Member

miq-bot commented Dec 15, 2016

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

@vecerek vecerek force-pushed the toolbar_refactoring__instance_buttons branch from 3c6bfd4 to c18653a Compare December 15, 2016 20:54
@miq-bot
Copy link
Member

miq-bot commented Dec 16, 2016

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

@vecerek vecerek force-pushed the toolbar_refactoring__instance_buttons branch from c18653a to c2f6ebe Compare December 16, 2016 09:01
jzigmund
jzigmund suggested changes Dec 16, 2016
View reviewed changes
Copy link

@jzigmund jzigmund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Compare and the Check Compliance buttons disappeared from 'All Instances' view, please fix it.

spec/helpers/application_helper/buttons/instance_check_compare_spec.rb
it { expect(subject.visible?).to be_truthy }
end
context 'when record is not OrchestrationStack' do
let(:record) { FactoryGirl.create(:orchestration_stack) }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when record is not OrchestrationStack ? :-)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll have that corrected

@vecerek
Copy link
Author

vecerek commented Dec 16, 2016

@jzigmund I've just pushed your requested changes. Let me know, whether you're satisfied with all the rest.

/cc @martinpovolny

@PanSpagetka
Copy link
Contributor

LOOKS GOOOOD 👍

@miq-bot
Copy link
Member

miq-bot commented Dec 19, 2016

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

@vecerek vecerek force-pushed the toolbar_refactoring__instance_buttons branch from 35c6006 to b854f40 Compare December 20, 2016 07:36
@miq-bot
Copy link
Member

miq-bot commented Dec 20, 2016

Checked commits vecerek/manageiq@be8a8f5~...b854f40 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
9 files checked, 0 offenses detected
Everything looks good. 🍪

@martinpovolny martinpovolny added this to the Sprint 51 Ending Jan 2, 2017 milestone Dec 20, 2016
@martinpovolny martinpovolny merged commit 5ff1005 into ManageIQ:master Dec 20, 2016
@vecerek vecerek deleted the toolbar_refactoring__instance_buttons branch February 23, 2017 09:51
@vecerek vecerek mentioned this pull request Feb 23, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzigmund jzigmund jzigmund requested changes

Assignees

@martinpovolny martinpovolny

Labels
refactoring ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vecerek @miq-bot @PanSpagetka @jzigmund @martinpovolny @chessbyte