-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add physical server REST api #14028
Add physical server REST api #14028
Conversation
Closing and reopening pull request to re-run travis tests |
@miq-bot add_label: providers/physical-infrastructure |
Closing to rerun travis test with upstream resolutions |
Re-open to run travis tests with upstream resolution |
app/models/host.rb
Outdated
|
||
|
||
# Physical infra reference | ||
has_one :physical_server, :foreign_key => "serial_number", :primary_key => "service_tag", :class_name => "PhysicalServer" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a repeat of the commits in #14026
app/models/physical_server.rb
Outdated
|
||
acts_as_miq_taggable | ||
|
||
belongs_to :ext_management_system, :foreign_key => :ems_id, :class_name => "ManageIQ::Providers::PhysicalInfraManager" | ||
|
||
default_value_for :enabled, true | ||
has_one :host, :foreign_key => "service_tag", :primary_key => "serial_number" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a repeat of the commits in #14026
@Fryguy There are some rubocop complaints on this PR about naming is_refreshable to refreshable? . Can those comments be ignored or do you recommend that we follow the suggested naming convention? |
Re-open to rerun travis tests |
Re-open to run travis tests |
Close and re-open to run travis tests |
Re-open to re-run travis tests |
This pull request is not mergeable. Please rebase and repush. |
/cc @imtayadeway |
@miq-bot add_label enhancement, providers/physical_infrastructure |
@miq-bot remove_label wip |
This pull request is not mergeable. Please rebase and repush. |
This pull request is not mergeable. Please rebase and repush. |
-modifies the host and physical server controller -updates the physical server and host model
-also syncs updates from PR 14026 so host, physical references match updated strategy
to use physical_server_url and leverage FactoryGirl instances more fully
use variable desc instead of string desc in log statement
Checked commits https://github.com/lenovo/manageiq/compare/b345df4fb935134f9719e7bafff7d9c0f5c6edca~...2f20e3a0e7ed7233e48a714d7446926e43f9d85b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/models/physical_server.rb
|
Add support for REST API operations against the physical server. Includes
power on, power off, restart, loc LED on/off/blinking.
Depends on PR: #14026
@miq-bot add_label: wip, providers/physical_infrastructure