Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add physical server REST api #14028

Merged
merged 21 commits into from
Apr 24, 2017
Merged

Add physical server REST api #14028

merged 21 commits into from
Apr 24, 2017

Conversation

rodneyhbrown7
Copy link

Add support for REST API operations against the physical server. Includes
power on, power off, restart, loc LED on/off/blinking.

Depends on PR: #14026

@miq-bot add_label: wip, providers/physical_infrastructure

@rodneyhbrown7
Copy link
Author

Closing and reopening pull request to re-run travis tests

@rodneyhbrown7 rodneyhbrown7 reopened this Feb 23, 2017
@rodneyhbrown7
Copy link
Author

@miq-bot add_label: providers/physical-infrastructure

@rodneyhbrown7
Copy link
Author

Closing to rerun travis test with upstream resolutions

@rodneyhbrown7
Copy link
Author

Re-open to run travis tests with upstream resolution

@rodneyhbrown7 rodneyhbrown7 reopened this Feb 23, 2017


# Physical infra reference
has_one :physical_server, :foreign_key => "serial_number", :primary_key => "service_tag", :class_name => "PhysicalServer"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a repeat of the commits in #14026


acts_as_miq_taggable

belongs_to :ext_management_system, :foreign_key => :ems_id, :class_name => "ManageIQ::Providers::PhysicalInfraManager"

default_value_for :enabled, true
has_one :host, :foreign_key => "service_tag", :primary_key => "serial_number"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a repeat of the commits in #14026

@rodneyhbrown7
Copy link
Author

@Fryguy There are some rubocop complaints on this PR about naming is_refreshable to refreshable? . Can those comments be ignored or do you recommend that we follow the suggested naming convention?

@rodneyhbrown7
Copy link
Author

Re-open to rerun travis tests

@rodneyhbrown7
Copy link
Author

Re-open to run travis tests

@rodneyhbrown7
Copy link
Author

Close and re-open to run travis tests

@rodneyhbrown7
Copy link
Author

Re-open to re-run travis tests

@rodneyhbrown7 rodneyhbrown7 reopened this Mar 13, 2017
@miq-bot
Copy link
Member

miq-bot commented Mar 16, 2017

This pull request is not mergeable. Please rebase and repush.

@imtayadeway
Copy link
Contributor

/cc @imtayadeway

@rodneyhbrown7 rodneyhbrown7 changed the title [WIP] Add ops to physical server [WIP] Add physical server REST api Mar 23, 2017
@rodneyhbrown7
Copy link
Author

@miq-bot add_label enhancement, providers/physical_infrastructure

@rodneyhbrown7
Copy link
Author

@miq-bot remove_label wip

@miq-bot
Copy link
Member

miq-bot commented Apr 19, 2017

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Apr 24, 2017

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Apr 24, 2017

Checked commits https://github.com/lenovo/manageiq/compare/b345df4fb935134f9719e7bafff7d9c0f5c6edca~...2f20e3a0e7ed7233e48a714d7446926e43f9d85b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
8 files checked, 4 offenses detected

app/models/physical_server.rb

@blomquisg blomquisg merged commit fbf1f4d into ManageIQ:master Apr 24, 2017
@chessbyte chessbyte added this to the Sprint 59 Ending Apr 24, 2017 milestone Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants