Update firmware refs #14034
Update firmware refs #14034
Conversation
app/models/host.rb
Outdated
|
|
||
|
|
||
| # Physical infra reference | ||
| has_one :physical_server, :foreign_key => "serial_number", :primary_key => "service_tag", :class_name => "PhysicalServer" |
There was a problem hiding this comment.
This is a repeat of the commits in #14026
app/models/physical_server.rb
Outdated
| @@ -6,6 +6,7 @@ class PhysicalServer < ApplicationRecord | |||
| belongs_to :ext_management_system, :foreign_key => :ems_id, :class_name => "ManageIQ::Providers::PhysicalInfraManager" | |||
|
|
|||
| default_value_for :enabled, true | |||
| has_one :host, :foreign_key => "service_tag", :primary_key => "serial_number" | |||
There was a problem hiding this comment.
This is a repeat of the commits in #14026
There was a problem hiding this comment.
Julian, is it ok that this is a repeat of commits in 14026? When this is applied these commits will be skipped correct? Or should we regenerate the PR when 14026 is approved?
|
Closing request to re-run travis tests |
|
Close and reopen to run travis |
|
Reopen to run travis |
|
This pull request is not mergeable. Please rebase and repush. |
|
@miq-bot remove_label wip |
|
@juliancheal , @blomquisg any concerns about how firmware is associated here? |
|
@miq-bot remove_label wip |
-modifies the host and physical server controller -updates the physical server and host model
|
Checked commits https://github.com/lenovo/manageiq/compare/b0ea2d2ac14f66379ebbd76dfdc9c82e635a8b5c~...1fc35c4110ab148a95280f6dd123d55fe816b2b4 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
This pull request is not mergeable. Please rebase and repush. |
|
Closing based on changes in #14430 |
Add firmware model and add firmware list into the physical Server controller response
Builds on PR: #14025, #14026, #14028
@miq_bot add_label: wip, providers/physical-infrastructure