Add missing fields to Middleware views #14115
Conversation
The fields were not being shown because the associations were not being loaded. This fixes this, effectively adding data to those columns: Middleware Servers: - Provider Middleware Domains: - Server Middleware Deployments: - Server - Hostname Middleware Datasources: - Server - Hostname Middleware Messagings: - Server
|
Checked commit cfcosta@c0ad2e8 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@martinpovolny huh - didn't think I removed any includes that were not in the actual report I'll scan through that PR again to see if this happened anywhere else this seems to work from a data layer for me. researching |
|
I don't see why these are necessary. not sure why it is not deriving the proper includes automatically |
|
@kbrock what do you think we should do then? Add the includes and then try to fix the bug (in that case defining includes make them a no-op), or try to fix the bug and not merge this? |
|
FYI - I'm rolling back these changes on all views until I can fix underlying problem in the report files. Thank you for bring up this issue and bringing up the fix. |
Bugzilla Ticket: https://bugzilla.redhat.com/show_bug.cgi?id=1422584
The fields were not being shown because the associations were not being
loaded. This fixes this, effectively adding data to those columns:
Middleware Servers:
Middleware Domains:
Middleware Deployments:
Middleware Datasources:
Middleware Messagings: