Reports: remove need to declare includes

[kbrock]

Blocked:

• Report both includes #13639 (first 3 commits) - simplification of the includes.

For reports, the columns are stated 2 times:

• includes which defines the joined table columns.
• cols which defines the database columns in the base table.
• sort_cols which defines the joined table columns and the base table columns, and this is ordered.

This change focuses on the unnecessary includes. If the value is missing, the report simply derives the value from sort_cols.

The long term goal is to just specify the columns once (i.e. sort_cols) and not require includes or cols. (they would be supported, just not required) This will simplify extracting metadata from reports.

@lpichler Just double checking custom attributes with you. Pretty sure they are in cols and not includes but wanted to double check.

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[martinpovolny]

Looks good to me.

Are there any impacts on the report editor? Guess there might be if we load a report w/o the includes.

[isimluk]

👍

[lpichler]

@lpichler Just double checking custom attributes with you. Pretty sure they are in cols and not includes but wanted to double check.

Yes, that's true. I am doing it in special method. (I'll check whether I can revamp it with your stuff)

[kbrock]

@martinpovolny thanks. good eye.

I'm guessing include_for_find is not in the editor?
I will have to track down the report editor and check that out

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[miq-bot]

Checked commits kbrock/manageiq@400581d~...3af1aeb with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🍪

[kbrock]

@martinpovolny Regarding the report editor
This PR is only for product/views, and nothing in product/reports, so this will not touch the reports editor.

[kbrock]

NOTE: reverting these report changes in #14439 - MiqReport#build_reportable_data is a little too complex for me to tackle right now. Safer to revert and address at a later time.