Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Containers list views not show Provider/Project name #14243

Closed
wants to merge 1 commit into from
Closed

Fix Containers list views not show Provider/Project name #14243

wants to merge 1 commit into from

Conversation

zakiva
Copy link
Contributor

@zakiva zakiva commented Mar 9, 2017 •
edited
Loading

@zakiva
Copy link
Contributor Author

zakiva commented Mar 9, 2017

@miq-bot add_label providers/containers, bug

@zakiva
Copy link
Contributor Author

zakiva commented Mar 9, 2017

@simon3z @zeari Please review

@miq-bot
Copy link
Member

miq-bot commented Mar 9, 2017

Checked commit zakiva@584337d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. ⭐

@simon3z
Copy link
Contributor

simon3z commented Mar 9, 2017

LGTM 👍

@miq-bot assign h-kataria

@h-kataria
Copy link
Contributor

looks good, @Fryguy please merge

@h-kataria
Copy link
Contributor

@zakiva can you please add before/after screenshots.

@h-kataria
Copy link
Contributor

@miq-bot assign fryguy

@miq-bot
Copy link
Member

miq-bot commented Mar 9, 2017

@h-kataria 'fryguy' is an invalid assignee, ignoring...

@h-kataria
Copy link
Contributor

@miq-bot assign Fryguy

@miq-bot miq-bot assigned Fryguy and unassigned h-kataria Mar 9, 2017
@zakiva
Copy link
Contributor Author

zakiva commented Mar 9, 2017

@zakiva can you please add before/after screenshots.

@h-kataria Added in the description, thanks.

@zakiva
Copy link
Contributor Author

zakiva commented Mar 16, 2017

@Fryguy @chessbyte Can you please review?

@zakiva
Copy link
Contributor Author

zakiva commented Mar 21, 2017

@blomquisg Please review

@miq-bot
Copy link
Member

miq-bot commented Mar 24, 2017

This pull request is not mergeable. Please rebase and repush.

@zakiva
Copy link
Contributor Author

zakiva commented Mar 27, 2017 •
edited
Loading

The issue was introduced in #13675 which was reverted in #14439, closing.

@zakiva zakiva closed this Mar 27, 2017
@zakiva
Copy link
Contributor Author

zakiva commented Mar 27, 2017

cc @kbrock

@kbrock
Copy link
Member

kbrock commented Mar 27, 2017

@zakiva thanks - Sorry I didn't see this. (glad I could help)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeari zeari zeari approved these changes

@simon3z simon3z simon3z approved these changes

Assignees

@Fryguy Fryguy

Labels
bug providers/containers unmergeable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@zakiva @miq-bot @simon3z @h-kataria @kbrock @zeari @Fryguy