Expose attach/detach method for volume #14289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyvesel
force-pushed
the
expose_attach_detach_for_cloud_volume
branch
from
c808552
to
5802c2a
Compare
andyvesel
force-pushed
the
expose_attach_detach_for_cloud_volume
branch
from
5802c2a
to
0f11a5b
Compare
|
Checked commit andyvesel@0f11a5b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Looks good to me 👍 |
andyvesel
changed the title
gmcculloug
reviewed
Mar 20, 2017
| @@ -10,5 +10,7 @@ class MiqAeServiceCloudVolume < MiqAeServiceModelBase | |||
| expose :cloud_volume_backups, :association => true | |||
| expose :cloud_volume_snapshots, :association => true | |||
| expose :attachments, :association => true | |||
| expose :attach_volume, :override_return => nil | |||
| expose :detach_volume, :override_return => nil | |||
There was a problem hiding this comment.
Is it possible to return a success or failure status of some kind? The user will have no indication if the method was successful if we always return nil.
There was a problem hiding this comment.
Thanks for comment. These model methods raise an error on failure or nothing meaningful on success. Would :override_return => true work or should we update methods body to return true/false (or something better)?
There was a problem hiding this comment.
I think we are good it the backing method raises an error. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose
attachanddetachmethods for Cloud Volume