Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose attach/detach method for volume #14289

Merged
merged 1 commit into from
Mar 20, 2017
Merged

Expose attach/detach method for volume #14289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/miq_automation_engine/service_models/miq_ae_service_cloud_volume.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,7 @@ class MiqAeServiceCloudVolume < MiqAeServiceModelBase
expose :cloud_volume_backups, :association => true
expose :cloud_volume_snapshots, :association => true
expose :attachments, :association => true
expose :attach_volume, :override_return => nil
expose :detach_volume, :override_return => nil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to return a success or failure status of some kind? The user will have no indication if the method was successful if we always return nil.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for comment. These model methods raise an error on failure or nothing meaningful on success. Would :override_return => true work or should we update methods body to return true/false (or something better)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are good it the backing method raises an error. Thanks.

end
end