Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DARGA] Add RBAC for rss feeds and #14316 #14308

Merged
merged 7 commits into from
Mar 14, 2017
Merged

[DARGA] Add RBAC for rss feeds and #14316 #14308

merged 7 commits into from
Mar 14, 2017

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Mar 13, 2017 •
edited
Loading

darga version of #14041

cc @gtanzillo

@miq-bot assign @simaishi

@miq-bot add_label rbac, enhancement

Links
https://bugzilla.redhat.com/show_bug.cgi?id=1418961
Darga PRs for the BZ:
#14316
#14308 (this PR)

@lpichler
Pass user or group to the rss generator
6b7a5f5 
to be able use it for RBAC
@lpichler
Add RBAC call for items in RSS Feed
5e979f6 
and process user or group as parameter for RBAC
@lpichler
Add spec for RSS feed generation
ff4229b
@lpichler
Fix order clause to determine order column from concrete table
2245103 
otherwise it leads to error ambiguous column when RBAC was added.
@simaishi simaishi requested a review from gtanzillo March 13, 2017 20:08
@lpichler lpichler closed this Mar 14, 2017
@lpichler lpichler reopened this Mar 14, 2017
@lpichler lpichler mentioned this pull request Mar 14, 2017
Closed
@lpichler
Copy link
Contributor Author

@gtanzillo
Differences in only in caller on RBAC, there was Rbac.filtered in darga

@lpichler lpichler closed this Mar 14, 2017
@lpichler lpichler reopened this Mar 14, 2017
@lpichler
Add scoping to tenant for resources in performance reports
c373db4 
- visible ids of resource class are determined for tenant
- those ids are used for filtering as well
@lpichler
Add factory for VmPerfomance
6921903
@lpichler
Specs for tenant scoping for VmPerformance
e01041f
@lpichler lpichler changed the title [DARGA] Add RBAC for rss feeds [DARGA] Add RBAC for rss feeds and #14316 Mar 14, 2017
@lpichler
Copy link
Contributor Author

I moved both PRs to this,
there is old darga pr for performance reports #14316

@miq-bot
Copy link
Member

miq-bot commented Mar 14, 2017

Checked commits lpichler/manageiq@6b7a5f5~...e01041f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
6 files checked, 1 offense detected

app/models/rbac.rb

  • ❗ - Line 203, Col 19 - Style/TrailingUnderscoreVariable - Do not use trailing _s in parallel assignment. Prefer filtered_ids, = calc_filtered_ids(parent_class, rbac_filters, user, miq_group, scope_tenant_filter).

gtanzillo
gtanzillo approved these changes Mar 14, 2017
View reviewed changes
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Reviewed with @lpichler, looks good.

@lpichler lpichler closed this Mar 14, 2017
@lpichler lpichler reopened this Mar 14, 2017
@lpichler lpichler closed this Mar 14, 2017
@lpichler lpichler reopened this Mar 14, 2017
@simaishi simaishi merged commit 98b56a3 into ManageIQ:darga Mar 14, 2017
This was referenced Mar 14, 2017
Merged
Merged
@chessbyte chessbyte added this to the Sprint 57 Ending Mar 27, 2017 milestone Mar 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtanzillo gtanzillo gtanzillo approved these changes

Assignees

@simaishi simaishi

Labels
core/rbac enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lpichler @miq-bot @gtanzillo @chessbyte @simaishi