Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DARGA] Add rbac to resouces for perfomance reports #14316

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Mar 14, 2017

darga version of #14095

cc @gtanzillo

@miq-bot assign @simaishi

@miq-bot add_label rbac, enhancement

Links
https://bugzilla.redhat.com/show_bug.cgi?id=1418961
Darga PRs for the BZ:
#14316 (this PR)
#14308

- visible ids of resource class are determined for tenant
- those ids are used for filtering as well
@miq-bot
Copy link
Member

miq-bot commented Mar 14, 2017

Checked commits lpichler/manageiq@5e4966b~...f5b629c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 1 offense detected

app/models/rbac.rb

  • ❗ - Line 203, Col 19 - Style/TrailingUnderscoreVariable - Do not use trailing _s in parallel assignment. Prefer filtered_ids, = calc_filtered_ids(parent_class, rbac_filters, user, miq_group, scope_tenant_filter).

@lpichler
Copy link
Contributor Author

@gtanzillo

differences regard to upstream PR:
there couple differences because RBAC sort of changed structrure,

but bigger one is about scoping
5e4966b#diff-c51171acee026d8d9d3cd886ccad2954R198
instead of
39d0469#diff-8d948055de14ced0e63abf9637a9a788R453 (as it is in master)

@lpichler lpichler closed this Mar 14, 2017
@lpichler lpichler reopened this Mar 14, 2017
@lpichler
Copy link
Contributor Author

closing, moved to #14308

@lpichler lpichler closed this Mar 14, 2017
simaishi added a commit that referenced this pull request Mar 14, 2017
[DARGA] Add RBAC for rss feeds and #14316
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants