Add features to physical servers pages #14709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gabrielsvinha
commented
Apr 10, 2017
•
gabrielsvinha
commented
- Adds operations for physical server buttons.
- Adds modify actions for physical server buttons.
5 tasks
|
Gabriel this overlaps with #14028 |
db/fixtures/miq_product_features.yml
Outdated
| @@ -6399,8 +6399,54 @@ | |||
| :identifier: physical_server_show_list | |||
| - :name: Show | |||
| :description: Display Individual Physical Server | |||
| :feature_type: view | |||
| :feature_type: view | |||
There was a problem hiding this comment.
please, remove the extra space here
thx!
|
@gabrielsvinha : does this really depend on the UI PR? I guess it's the other way round, isn't it?We need this one to merge first, right? I think that we can merge this except for the extra space. @rodneyhbrown7 : do you agree or should #14028 be merged first? |
|
@martinpovolny you're right. UI depends on this one, thnks. |
|
Checked commits https://github.com/lenovo/manageiq/compare/671db9a91da149a78a6bf908892ee0e5a6131d0d~...d28394d2d5919c43080bb9efa9170d08f64edf65 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Removes spaces from miq product features
|
Agreed this one can be merged first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.