Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default server.cer #14858

Merged
merged 1 commit into from
Apr 25, 2017
Merged

Remove default server.cer #14858

merged 1 commit into from
Apr 25, 2017

Conversation

isimluk
Copy link
Member

@isimluk isimluk commented Apr 24, 2017

Depends on

ManageIQ/manageiq-appliance#119

What

https://access.redhat.com/security/cve/CVE-2016-4457

The custom certificate will get generate at first server start-up by initialize_appliance.sh. Merge only after ManageIQ/manageiq-appliance#119.

@isimluk
Remove default server.cer
c83f798 
CVE-2016-4457

The custom certificate will get generate at first server start-up
by initialize_appliance.sh. Merge after ManageIQ/manageiq-appliance#119.
@miq-bot
Copy link
Member

miq-bot commented Apr 24, 2017

Checked commit isimluk@c83f798 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. ⭐

gtanzillo
gtanzillo approved these changes Apr 25, 2017
View reviewed changes
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@gtanzillo gtanzillo added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 25, 2017
@gtanzillo gtanzillo merged commit 08d6d4f into ManageIQ:master Apr 25, 2017
@isimluk isimluk deleted the rhbz#1340877 branch April 25, 2017 10:21
@isimluk
Copy link
Member Author

isimluk commented Apr 26, 2017

Adding fine/no until the ManageIQ/manageiq-appliance#119 is merged. Then, we can backport.

@isimluk isimluk mentioned this pull request Apr 27, 2017
Merged
@carbonin carbonin added fine/yes and removed fine/no labels Apr 27, 2017
simaishi pushed a commit that referenced this pull request May 1, 2017
@gtanzillo @simaishi
Merge pull request #14858 from isimluk/rhbz#1340877
8b90eb0 
Remove default server.cer
(cherry picked from commit 08d6d4f)

https://bugzilla.redhat.com/show_bug.cgi?id=1390815
@simaishi
Copy link
Contributor

simaishi commented May 1, 2017

Fine backport details:

$ git log -1
commit 8b90eb035f013e88be3075324320bd46724608cb
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Mon Apr 24 22:29:09 2017 -0400

    Merge pull request #14858 from isimluk/rhbz#1340877
    
    Remove default server.cer
    (cherry picked from commit 08d6d4f35e923b698e23ef94509d8d22706aded0)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1390815

simaishi pushed a commit that referenced this pull request May 11, 2017
@gtanzillo @simaishi
Merge pull request #14858 from isimluk/rhbz#1340877
d7e7248 
Remove default server.cer
(cherry picked from commit 08d6d4f)

https://bugzilla.redhat.com/show_bug.cgi?id=1390816
@simaishi
Copy link
Contributor

Euwe backport details:

$ git log -1
commit d7e7248b119a2db943fe810f354c4fbfac544de2
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Mon Apr 24 22:29:09 2017 -0400

    Merge pull request #14858 from isimluk/rhbz#1340877
    
    Remove default server.cer
    (cherry picked from commit 08d6d4f35e923b698e23ef94509d8d22706aded0)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1390816

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtanzillo gtanzillo gtanzillo approved these changes

Assignees

@gtanzillo gtanzillo

Labels
appliance blocker bug euwe/backported fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@isimluk @miq-bot @simaishi @gtanzillo @carbonin