Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default server.cer.key #14917

Merged
merged 1 commit into from
Apr 27, 2017
Merged

Conversation

isimluk
Copy link
Member

@isimluk isimluk commented Apr 27, 2017

A follow-up on #14858

Thanks @carbonin for noticing this was missing!!! 🥇

What

https://access.redhat.com/security/cve/CVE-2016-4457

The custom certificate will get generate at first server start-up by initialize_appliance.sh. Merge only after ManageIQ/manageiq-appliance#119.

@miq-bot
Copy link
Member

miq-bot commented Apr 27, 2017

Checked commit isimluk@7e0d6c1 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@carbonin carbonin self-assigned this Apr 27, 2017
@carbonin carbonin merged commit a42fc27 into ManageIQ:master Apr 27, 2017
@carbonin carbonin added this to the Sprint 60 Ending May 8, 2017 milestone Apr 27, 2017
@carbonin carbonin added fine/yes and removed fine/no labels Apr 27, 2017
simaishi pushed a commit that referenced this pull request May 1, 2017
@simaishi
Copy link
Contributor

simaishi commented May 1, 2017

Fine backport details:

$ git log -1
commit e2536bb736dcf2aab7233fb1d730d5e7cc1ea968
Author: Nick Carboni <ncarboni@redhat.com>
Date:   Thu Apr 27 09:18:52 2017 -0400

    Merge pull request #14917 from isimluk/rhbz#1340877-2
    
    Remove default server.cer.key
    (cherry picked from commit a42fc278a21da14098c6ad8cc064a6e023a16699)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1390815

@isimluk isimluk deleted the rhbz#1340877-2 branch May 2, 2017 10:36
simaishi pushed a commit that referenced this pull request May 11, 2017
@simaishi
Copy link
Contributor

Euwe backport details:

$ git log -1
commit 4a2831a523a68a5d515ba3a9c12f2c01302833d1
Author: Nick Carboni <ncarboni@redhat.com>
Date:   Thu Apr 27 09:18:52 2017 -0400

    Merge pull request #14917 from isimluk/rhbz#1340877-2
    
    Remove default server.cer.key
    (cherry picked from commit a42fc278a21da14098c6ad8cc064a6e023a16699)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1390816

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants