Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RBAC for User model regard to allowed role #14898

Merged
merged 3 commits into from
May 2, 2017
Merged

RBAC for User model regard to allowed role #14898

merged 3 commits into from
May 2, 2017

Conversation

lpichler
Copy link
Contributor

follow up for #13689

Hide users with role which is disallowed for logged user's role. (according to this array )

@miq-bot add_label core, rbac, bug, fine/yes

@miq-bot assign @gtanzillo

@miq-bot
Copy link
Member

miq-bot commented Apr 26, 2017

Checked commits lpichler/manageiq@6a795af~...0481589 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks good. 🍰

This was referenced Apr 26, 2017
Merged
Merged
@lpichler
Copy link
Contributor Author

cc @isimluk

isimluk
isimluk approved these changes May 2, 2017
View reviewed changes
Copy link
Member

@isimluk isimluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Except I don't like the disallowed_roles that returns nil or false or list of disallowed roles.

Could you please consider a follow-up for disallowed_roles to always return list (i.e. empty list instead of nil and false)?

Thanks!

@isimluk isimluk assigned isimluk and unassigned gtanzillo May 2, 2017
@isimluk
Copy link
Member

isimluk commented May 2, 2017

I think we will need a bugzilla if we want fine/yes at this point.

@isimluk isimluk added this to the Sprint 60 Ending May 8, 2017 milestone May 2, 2017
@isimluk isimluk merged commit 5697c1c into ManageIQ:master May 2, 2017
@lpichler lpichler deleted the rbac_for_user_model_by_role branch May 2, 2017 12:05
@lpichler
Copy link
Contributor Author

lpichler commented May 2, 2017 •
edited
Loading

@isimluk yes sure in follow up 📝 PR, thanks!

gtanzillo
gtanzillo reviewed May 2, 2017
View reviewed changes
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lpichler
Copy link
Contributor Author

lpichler commented May 2, 2017

https://bugzilla.redhat.com/show_bug.cgi?id=1447370

simaishi pushed a commit that referenced this pull request May 2, 2017
@isimluk @simaishi
Merge pull request #14898 from lpichler/rbac_for_user_model_by_role
7d6e53f 
RBAC for User model regard to allowed role
(cherry picked from commit 5697c1c)

https://bugzilla.redhat.com/show_bug.cgi?id=1447373
@simaishi
Copy link
Contributor

simaishi commented May 2, 2017 •
edited
Loading

Added blocker label, as blocker PRs #14901 and #14903 depend on this PR.

Fine backport details:

$ git log -1
commit 7d6e53feb92e7653e735ce8cc1c1e3667ac5b476
Author: Šimon Lukašík <isimluk@fedoraproject.org>
Date:   Tue May 2 14:03:38 2017 +0200

    Merge pull request #14898 from lpichler/rbac_for_user_model_by_role
    
    RBAC for User model regard to allowed role
    (cherry picked from commit 5697c1c4d19c057fa0dbc55b82b83d25b9f17a42)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1447373

@lpichler
Copy link
Contributor Author

@miq-bot add_label euwe/yes

@lpichler
Copy link
Contributor Author

all related PRs:

#14898
#14901
#14903

simaishi pushed a commit that referenced this pull request Jun 20, 2017
@isimluk @simaishi
Merge pull request #14898 from lpichler/rbac_for_user_model_by_role
b18f998 
RBAC for User model regard to allowed role
(cherry picked from commit 5697c1c)

https://bugzilla.redhat.com/show_bug.cgi?id=1460979
@simaishi
Copy link
Contributor

Euwe backport details:

$ git log -1
commit b18f9982c9d07bec923f2e86823032ccc33b1cf1
Author: Šimon Lukašík <isimluk@fedoraproject.org>
Date:   Tue May 2 14:03:38 2017 +0200

    Merge pull request #14898 from lpichler/rbac_for_user_model_by_role
    
    RBAC for User model regard to allowed role
    (cherry picked from commit 5697c1c4d19c057fa0dbc55b82b83d25b9f17a42)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1460979

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtanzillo gtanzillo gtanzillo left review comments

@isimluk isimluk isimluk approved these changes

Assignees

@isimluk isimluk

Labels
blocker bug core/rbac core euwe/backported fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lpichler @miq-bot @isimluk @simaishi @gtanzillo