-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag visibility for User and MiqGroup model #14903
Tag visibility for User and MiqGroup model #14903
Conversation
3d55436
to
aa80335
Compare
aa80335
to
97de924
Compare
Checked commits lpichler/manageiq@da4f12a~...97de924 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
97de924
to
493d6f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good after walkthrough with @lpichler
…roups Tag visibility for User and MiqGroup model (cherry picked from commit 8340d21) https://bugzilla.redhat.com/show_bug.cgi?id=1447372
Fine backport details:
|
@miq-bot add_label euwe/yes |
…roups Tag visibility for User and MiqGroup model (cherry picked from commit 8340d21) https://bugzilla.redhat.com/show_bug.cgi?id=1460979
Euwe backport details:
|
depends on (reason for WIP):
#14898
#14901
this PR is starting with commit Add User and MiqGroup to allow be filtered by Tags
I am using
get_managed_filter_object_ids(to determine tagged items)
because only this method is related to User and MiqGroup model in methodcalc_filtered_ids
@miq-bot add_label wip, blocker, bug, fine/yes
@miq-bot assign @gtanzillo
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1442972 (this PR is first part of two for the BZ)