Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag visibility for User and MiqGroup model #14903

Merged

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Apr 26, 2017

depends on (reason for WIP):
#14898
#14901

this PR is starting with commit Add User and MiqGroup to allow be filtered by Tags

I am using get_managed_filter_object_ids(to determine tagged items) because only this method is related to User and MiqGroup model in method calc_filtered_ids

@miq-bot add_label wip, blocker, bug, fine/yes

@miq-bot assign @gtanzillo

Links

https://bugzilla.redhat.com/show_bug.cgi?id=1442972 (this PR is first part of two for the BZ)

@lpichler lpichler force-pushed the tag_visibility_for_user_and_groups branch from aa80335 to 97de924 Compare May 2, 2017 13:16
@gtanzillo gtanzillo removed the wip label May 2, 2017
@gtanzillo gtanzillo changed the title [WIP] Tag visibility for User and MiqGroup model Tag visibility for User and MiqGroup model May 2, 2017
@miq-bot
Copy link
Member

miq-bot commented May 2, 2017

Checked commits lpichler/manageiq@da4f12a~...97de924 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@lpichler lpichler force-pushed the tag_visibility_for_user_and_groups branch from 97de924 to 493d6f4 Compare May 2, 2017 13:32
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good after walkthrough with @lpichler

@gtanzillo gtanzillo added this to the Sprint 60 Ending May 8, 2017 milestone May 2, 2017
@gtanzillo gtanzillo merged commit 8340d21 into ManageIQ:master May 2, 2017
@lpichler lpichler deleted the tag_visibility_for_user_and_groups branch May 2, 2017 14:02
simaishi pushed a commit that referenced this pull request May 2, 2017
@simaishi
Copy link
Contributor

simaishi commented May 2, 2017

Fine backport details:

$ git log -1
commit f3e1bf965674f9611a5cd158080e6b07a9b4b5ce
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Tue May 2 09:55:06 2017 -0400

    Merge pull request #14903 from lpichler/tag_visibility_for_user_and_groups
    
    Tag visibility for User and MiqGroup model
    (cherry picked from commit 8340d21ae22c24bd1f5881e413065136c48a3d69)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1447372

@lpichler
Copy link
Contributor Author

@miq-bot add_label euwe/yes

@lpichler
Copy link
Contributor Author

lpichler commented Jun 20, 2017

all related PRs:
#14898
#14901
#14903

simaishi pushed a commit that referenced this pull request Jun 20, 2017
@simaishi
Copy link
Contributor

Euwe backport details:

$ git log -1
commit 3c74854045dd9015718814f9c2ad447dc439aceb
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Tue May 2 09:55:06 2017 -0400

    Merge pull request #14903 from lpichler/tag_visibility_for_user_and_groups
    
    Tag visibility for User and MiqGroup model
    (cherry picked from commit 8340d21ae22c24bd1f5881e413065136c48a3d69)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1460979

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants