Make TokenManager#token_ttl callable (evaluated at call time) #15124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we pass in a value that can change (i.e. settings), it's evaluated once at construction time and will never change. Thus, if a user changes the session time out setting, a restart of the server is required. By making this value callable we can delay evaluation until call time, which honors updated settings values. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1451848
|
Checked commits imtayadeway/manageiq@e3a880a~...9fa3858 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
jvlcek
reviewed
May 18, 2017
|
LGTM!! Thanks @imtayadeway for fixing this. 🎵 |
|
@miq-bot add-label fine/yes |
simaishi
pushed a commit
that referenced
this pull request
Jun 8, 2017
Make TokenManager#token_ttl callable (evaluated at call time) (cherry picked from commit e35b6c2) https://bugzilla.redhat.com/show_bug.cgi?id=1459987
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we pass in a value that can change (i.e. settings), it's evaluated
once at construction time and will never change. Thus, if a user
changes the session time out setting, a restart of the server is
required.
By making this value callable we can delay evaluation until call time,
which honors updated settings values.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1451848
/cc @isimluk @jvlcek
@miq-bot add-label bug, api
@miq-bot assign @abellotti